Generate constants for HTTP status codes and reason phrases using macro.

Generate constants for HTTP status codes and reason phrases using macro.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205202

[tyoshino (SeeGerritForStatus), 2013-06-07 17:10:02]

I forgot to update comments in http_status_code.h. Please review the patch set
4.
Thanks.

[wtc, 2013-06-07 21:24:18]

Patch set 4 LGTM. Thanks a lot!

https://codereview.chromium.org/16622002/diff/7001/net/http/http_status_code.h
File net/http/http_status_code.h (right):

https://codereview.chromium.org/16622002/diff/7001/net/http/http_status_code....
net/http/http_status_code.h:26: // This function doesn't cover all codes defined
in the registry. It returns an

doesn't cover => may not cover

registry => IANA registry

You covered all the codes defined in the registry, right? So this problem
will only occur when new status codes are added.

https://codereview.chromium.org/16622002/diff/7001/net/http/http_status_code_...
File net/http/http_status_code_list.h (right):

https://codereview.chromium.org/16622002/diff/7001/net/http/http_status_code_...
net/http/http_status_code_list.h:4: //

Nit: make this a blank line, without the //

https://codereview.chromium.org/16622002/diff/7001/net/http/http_status_code_...
net/http/http_status_code_list.h:8: // This File contains the list of HTTP
status codes. Taken from IANA HTTP Status

Nit: File => file

[tyoshino (SeeGerritForStatus), 2013-06-10 06:14:00]

https://codereview.chromium.org/16622002/diff/7001/net/http/http_status_code.h
File net/http/http_status_code.h (right):

https://codereview.chromium.org/16622002/diff/7001/net/http/http_status_code....
net/http/http_status_code.h:26: // This function doesn't cover all codes defined
in the registry. It returns an
On 2013/06/07 21:24:18, wtc wrote:
> 
> doesn't cover => may not cover
> 
Done

> registry => IANA registry
> 
Done

> You covered all the codes defined in the registry, right? So this problem
> will only occur when new status codes are added.
>  
I added reason phrases for all codes which were already defined in this file,
but it still doesn't cover all the codes defined in the IANA registry. So, I
kept this comment but just replaced "above" with "in the registry".

https://codereview.chromium.org/16622002/diff/7001/net/http/http_status_code_...
File net/http/http_status_code_list.h (right):

https://codereview.chromium.org/16622002/diff/7001/net/http/http_status_code_...
net/http/http_status_code_list.h:4: //
On 2013/06/07 21:24:18, wtc wrote:
> 
> Nit: make this a blank line, without the //

Done. So, like net_error_list.h, L7 should be also blank line? Or we just should
split copyright notice and file comment?

https://codereview.chromium.org/16622002/diff/7001/net/http/http_status_code_...
net/http/http_status_code_list.h:8: // This File contains the list of HTTP
status codes. Taken from IANA HTTP Status
On 2013/06/07 21:24:18, wtc wrote:
> 
> Nit: File => file

Done.

[commit-bot: I haz the power, 2013-06-10 06:14:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/16622002/13001

[commit-bot: I haz the power, 2013-06-10 07:13:07]

Retried try job too often on linux_chromeos for step(s) app_list_unittests,
ash_unittests, aura_unittests, base_unittests, browser_tests,
cacheinvalidation_unittests, check_deps, chromeos_unittests,
components_unittests, content_browsertests, content_unittests, crypto_unittests,
dbus_unittests, device_unittests, gpu_unittests, interactive_ui_tests,
ipc_tests, jingle_unittests, media_unittests, net_unittests, ppapi_unittests,
printing_unittests, sandbox_linux_unittests, sql_unittests, sync_unit_tests,
unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-06-10 08:21:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/16622002/13001

[commit-bot: I haz the power, 2013-06-10 13:18:50]

Change committed as 205202

[wtc, 2013-06-10 17:12:46]

Patch set 5 LGTM.

https://codereview.chromium.org/16622002/diff/7001/net/http/http_status_code_...
File net/http/http_status_code_list.h (right):

https://codereview.chromium.org/16622002/diff/7001/net/http/http_status_code_...
net/http/http_status_code_list.h:4: //

On 2013/06/10 06:14:00, tyoshino wrote:
>
> So, like net_error_list.h, L7 should be also blank line? Or we just should
> split copyright notice and file comment?

The latter. I mainly want us to split the copyright notice and file
comment. As for L7, I would also use // as you do, but a blank line
would also be fine.

[tyoshino (SeeGerritForStatus), 2013-06-11 03:21:14]

https://codereview.chromium.org/16622002/diff/7001/net/http/http_status_code_...
File net/http/http_status_code_list.h (right):

https://codereview.chromium.org/16622002/diff/7001/net/http/http_status_code_...
net/http/http_status_code_list.h:4: //
On 2013/06/10 17:12:47, wtc wrote:
> 
> On 2013/06/10 06:14:00, tyoshino wrote:
> >
> > So, like net_error_list.h, L7 should be also blank line? Or we just should
> > split copyright notice and file comment?
> 
> The latter. I mainly want us to split the copyright notice and file
> comment. As for L7, I would also use // as you do, but a blank line
> would also be fine.

All right. Thanks.