VM: Support fast calls to atan and atan2 in optimized code.

VM: Support fast calls to atan and atan2 in optimized code.

BUG=
R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/5e680a29385e7fc73cf72fd3e8e412e75ae425fd

[Florian Schneider, 2016-02-04 01:31:38]

fschneider@google.com changed reviewers:
+ vegorov@google.com

[kasperl, 2016-02-04 07:25:44]

kasperl@google.com changed reviewers:
+ kasperl@google.com

[kasperl, 2016-02-04 07:25:44]

Thanks for working on this!

For context, the benchmark that I'm trying to port to Dart uses atan2 quite a
lot; see
https://github.com/harrycheung/Mobile-App-Performance/blob/master/JavaScript/....

[Vyacheslav Egorov (Google), 2016-02-04 10:30:58]

LGTM

https://codereview.chromium.org/1662153002/diff/20001/runtime/vm/flow_graph_o...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/1662153002/diff/20001/runtime/vm/flow_graph_o...
runtime/vm/flow_graph_optimizer.cc:4573: // We know that first argument is
double, the second is num.
The comment is a bit confusing now because it does not apply to either atan
(it's a single argument function) or atan2 (it has two arguments but *both* are
num).

https://codereview.chromium.org/1662153002/diff/20001/runtime/vm/intermediate...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/1662153002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language.cc:3572:
static_cast<BinaryMathCFunction>(&atan2)));
I think this has to call to atan2_ieee to workaround some Windows specific
stuff.

[Florian Schneider, 2016-02-04 21:41:49]

https://codereview.chromium.org/1662153002/diff/20001/runtime/vm/flow_graph_o...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/1662153002/diff/20001/runtime/vm/flow_graph_o...
runtime/vm/flow_graph_optimizer.cc:4573: // We know that first argument is
double, the second is num.
On 2016/02/04 10:30:58, Vyacheslav Egorov (Google) wrote:
> The comment is a bit confusing now because it does not apply to either atan
> (it's a single argument function) or atan2 (it has two arguments but *both*
are
> num).

Done.

https://codereview.chromium.org/1662153002/diff/20001/runtime/vm/intermediate...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/1662153002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language.cc:3572:
static_cast<BinaryMathCFunction>(&atan2)));
On 2016/02/04 10:30:58, Vyacheslav Egorov (Google) wrote:
> I think this has to call to atan2_ieee to workaround some Windows specific
> stuff.

Yes. Done.

[Florian Schneider, 2016-02-04 21:57:41]

Description was changed from

==========
VM: Support fast calls to atan and atan2 in optimized code.

BUG=
==========

to

==========
VM: Support fast calls to atan and atan2 in optimized code.

BUG=
R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5e680a29385e7fc73cf72fd3e8e412e75ae425fd
==========

[Florian Schneider, 2016-02-04 21:57:42]

Committed patchset #3 (id:40001) manually as
5e680a29385e7fc73cf72fd3e8e412e75ae425fd (presubmit successful).