Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1662133002: Update to VS 2015 package with embedded UCRT (Closed)

Created:
4 years, 10 months ago by brucedawson
Modified:
4 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update to VS 2015 package with embedded UCRT Recent packaging changes in depot_tools have given us a package that appears to build Chromium with VS 2015 on machines without the UCRT installed. This switches VS 2015 builds to this package. This needs to be done separately from the switch to VS 2015 so that if that change is reverted we don't needlessly revert toolchains. BUG=440500 Committed: https://crrev.com/3bb12bc92eaea734f91c0c3dfbb6e8c5c0c8eb51 Cr-Commit-Position: refs/heads/master@{#373436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/vs_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
Still waiting on try jobs, but it looks like this is golden. I want this ...
4 years, 10 months ago (2016-02-04 01:10:52 UTC) #2
scottmg
lgtm
4 years, 10 months ago (2016-02-04 01:13:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662133002/1
4 years, 10 months ago (2016-02-04 01:16:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 02:31:56 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 02:32:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3bb12bc92eaea734f91c0c3dfbb6e8c5c0c8eb51
Cr-Commit-Position: refs/heads/master@{#373436}

Powered by Google App Engine
This is Rietveld 408576698