Issue 16621004: make empty string returnable by ReturnValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16621004: make empty string returnable by ReturnValue (Closed)

Created:
7 years, 6 months ago by dcarney

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

make empty string returnable by ReturnValue R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15054

Patch Set 2 : nit #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -11 lines)			Patch
	M	include/v8.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
	M	test/cctest/test-api.cc	View	1	3 chunks	+34 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with a nit. https://codereview.chromium.org/16621004/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/16621004/diff/1/test/cctest/test-api.cc#newcode1041 test/cctest/test-api.cc:1041: kNullReturnValue = 1, Is there ...

7 years, 6 months ago (2013-06-11 07:24:17 UTC) #2

dcarney

https://chromiumcodereview.appspot.com/16621004/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://chromiumcodereview.appspot.com/16621004/diff/1/test/cctest/test-api.cc#newcode1041 test/cctest/test-api.cc:1041: kNullReturnValue = 1, On 2013/06/11 07:24:17, Sven Panne wrote: ...

7 years, 6 months ago (2013-06-11 07:40:51 UTC) #3

dcarney

7 years, 6 months ago (2013-06-11 07:42:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r15054 (presubmit successful).

Expand Messages | Collapse Messages

Issue 16621004: make empty string returnable by ReturnValue (Closed)

Description

Patch Set 1 #

Patch Set 2 : nit #

Messages