Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 16621002: Add OWNERS to third_party/devscripts (Closed)

Created:
7 years, 6 months ago by Nils Barth (inactive)
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

third_party/devscripts is missing an OWNERS file, which it should have, and its absence means changes need to be approved by general third_party owners. This CL creates one, essentially the same as tools/checklicenses, as that's the script that uses this and these are the main editors of these files (per git blame): phajdan.jr@chromium.org thestig@chromium.org (without the 'set noparent', as parent approval ok in third_party) The absence of OWNERS caused presubmit failure on below issue, which this CL fixes: Issue 16426003: Add footer license check to licensecheck.pl and Perl to checklicenses.py https://chromiumcodereview.appspot.com/16426003/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
A third_party/devscripts/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nils Barth (inactive)
Hiyas Brett/Carlos/Darin, Quick CL adding OWNERS to third_party/devscripts so you don't have to approve CLs ...
7 years, 6 months ago (2013-06-07 06:06:27 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
7 years, 6 months ago (2013-06-07 17:59:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/16621002/1
7 years, 6 months ago (2013-06-08 10:43:08 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=136352
7 years, 6 months ago (2013-06-08 12:27:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/16621002/1
7 years, 6 months ago (2013-06-08 12:36:24 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-08 16:46:27 UTC) #6
Message was sent while issue was closed.
Change committed as 205073

Powered by Google App Engine
This is Rietveld 408576698