Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 1662063003: Improved support for images/bitmaps in SkJSONCanvas (Closed)

Created:
4 years, 10 months ago by ethannicholas
Modified:
4 years, 10 months ago
Reviewers:
joshualitt, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -13 lines) Patch
M tools/json/SkJSONCanvas.h View 3 chunks +14 lines, -0 lines 0 comments Download
M tools/json/SkJSONCanvas.cpp View 6 chunks +75 lines, -9 lines 0 comments Download
M tools/json/SkJSONRenderer.cpp View 5 chunks +66 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ethannicholas
4 years, 10 months ago (2016-02-03 21:41:29 UTC) #3
joshualitt
On 2016/02/03 21:41:29, ethannicholas wrote: lgtm
4 years, 10 months ago (2016-02-04 14:07:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662063003/1
4 years, 10 months ago (2016-02-04 14:10:26 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 14:45:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0bd103497a21c2cb30fd5382cedb706cbf4941fa

Powered by Google App Engine
This is Rietveld 408576698