url/BUILD.gn - Issue 1662053002: Move gn _run target generation into test(). (RELAND)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: url/BUILD.gn

Issue 1662053002: Move gn _run target generation into test(). (RELAND) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: +kbr changes Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: url/BUILD.gn

diff --git a/url/BUILD.gn b/url/BUILD.gn

index d403efbbe569864ac42aa24e9b4b3c0f33e59a60..692478473dd6f79cb4c23996b9c302d7f301892e 100644

--- a/url/BUILD.gn

+++ b/url/BUILD.gn

@@ -115,15 +115,6 @@ if (is_android) {

# TODO(dpranke): crbug.com/360936. Get this to build and run on Android.

if (!is_android) {

- # TODO(GYP): Delete this after we've converted everything to GN.

- # The _run targets exist only for compatibility w/ GYP.

- group("url_unittests_run") {

- testonly = true

- deps = [

- ":url_unittests",

- ]

- }

test("url_unittests") {

sources = [

"gurl_unittest.cc",

« no previous file with comments | « ui/wm/BUILD.gn ('k') | no next file » | no next file with comments »