extensions/shell/BUILD.gn - Issue 1662053002: Move gn _run target generation into test(). (RELAND)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/BUILD.gn

Issue 1662053002: Move gn _run target generation into test(). (RELAND) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: +kbr changes Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/shell/BUILD.gn

diff --git a/extensions/shell/BUILD.gn b/extensions/shell/BUILD.gn

index 52e3cabee3f75a4dea804fa549a9a19d02ae203e..a98d7042d28897ab22c1f50d92f1edfd027c0446 100644

--- a/extensions/shell/BUILD.gn

+++ b/extensions/shell/BUILD.gn

@@ -145,15 +145,6 @@ if (!(is_chromeos && !use_ozone)) {

}

-# TODO(GYP): Delete this after we've converted everything to GN.

-# The _run targets exist only for compatibility w/ GYP.

-group("app_shell_unittests_run") {

- testonly = true

- deps = [

- ":app_shell_unittests",

- ]

test("app_shell_unittests") {

sources = rebase_path(app_shell_gypi_values.app_shell_unittests_sources,

".",

« no previous file with comments | « extensions/BUILD.gn ('k') | gin/BUILD.gn » ('j') | no next file with comments »