Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: extensions/BUILD.gn

Issue 1662053002: Move gn _run target generation into test(). (RELAND) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: +kbr changes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/BUILD.gn ('k') | extensions/shell/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # TODO(rockot) bug 505926: Don't include chrome files from here. 5 # TODO(rockot) bug 505926: Don't include chrome files from here.
6 # See chrome_browser_tests_extensions_sources below 6 # See chrome_browser_tests_extensions_sources below
7 import("//chrome/chrome_tests.gni") 7 import("//chrome/chrome_tests.gni")
8 import("//extensions/extensions.gni") 8 import("//extensions/extensions.gni")
9 import("//testing/test.gni") 9 import("//testing/test.gni")
10 import("//tools/grit/grit_rule.gni") 10 import("//tools/grit/grit_rule.gni")
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 "//content/shell:resources", 134 "//content/shell:resources",
135 "//extensions/shell:resources", 135 "//extensions/shell:resources",
136 "//extensions/strings", 136 "//extensions/strings",
137 "//third_party/WebKit/public:image_resources", 137 "//third_party/WebKit/public:image_resources",
138 "//third_party/WebKit/public:resources", 138 "//third_party/WebKit/public:resources",
139 "//ui/resources", 139 "//ui/resources",
140 "//ui/strings", 140 "//ui/strings",
141 ] 141 ]
142 } 142 }
143 143
144 # TODO(GYP): Delete this after we've converted everything to GN.
145 # The _run targets exist only for compatibility w/ GYP.
146 group("extensions_unittests_run") {
147 testonly = true
148 deps = [
149 ":extensions_unittests",
150 ]
151 }
152
153 test("extensions_unittests") { 144 test("extensions_unittests") {
154 sources = 145 sources =
155 rebase_path(extensions_tests_gypi_values.extensions_unittests_sources, 146 rebase_path(extensions_tests_gypi_values.extensions_unittests_sources,
156 ".", 147 ".",
157 "//extensions") 148 "//extensions")
158 149
159 sources += [ 150 sources += [
160 # TODO(rockot): DisplayInfoProvider::Create() is only implemented in Chrome 151 # TODO(rockot): DisplayInfoProvider::Create() is only implemented in Chrome
161 # and app_shell. This is wrong. 152 # and app_shell. This is wrong.
162 "shell/browser/shell_display_info_provider.cc", 153 "shell/browser/shell_display_info_provider.cc",
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 202
212 # TODO(rockot): There are two implementations of VpnServiceFactory, a 203 # TODO(rockot): There are two implementations of VpnServiceFactory, a
213 # stub in app_shell and a real one in Chrome. This is wrong. 204 # stub in app_shell and a real one in Chrome. This is wrong.
214 "shell/browser/api/vpn_provider/vpn_service_factory.cc", 205 "shell/browser/api/vpn_provider/vpn_service_factory.cc",
215 ] 206 ]
216 207
217 deps += [ "//chromeos:test_support" ] 208 deps += [ "//chromeos:test_support" ]
218 } 209 }
219 } 210 }
220 211
221 # TODO(GYP): Delete this after we've converted everything to GN.
222 # The _run targets exist only for compatibility w/ GYP.
223 group("extensions_browsertests_run") {
224 testonly = true
225 deps = [
226 ":extensions_browsertests",
227 ]
228 }
229
230 test("extensions_browsertests") { 212 test("extensions_browsertests") {
231 sources = 213 sources =
232 rebase_path(extensions_tests_gypi_values.extensions_browsertests_sources, 214 rebase_path(extensions_tests_gypi_values.extensions_browsertests_sources,
233 ".", 215 ".",
234 "//extensions") 216 "//extensions")
235 217
236 data = [ 218 data = [
237 "test/data/", 219 "test/data/",
238 "//net/data/", 220 "//net/data/",
239 "//net/tools/testserver/", 221 "//net/tools/testserver/",
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 "//testing/gtest", 369 "//testing/gtest",
388 "//third_party/hunspell", 370 "//third_party/hunspell",
389 "//third_party/icu", 371 "//third_party/icu",
390 "//third_party/libpng", 372 "//third_party/libpng",
391 "//third_party/zlib", 373 "//third_party/zlib",
392 "//ui/base:test_support", 374 "//ui/base:test_support",
393 "//ui/resources:ui_test_pak", 375 "//ui/resources:ui_test_pak",
394 "//ui/web_dialogs:test_support", 376 "//ui/web_dialogs:test_support",
395 ] 377 ]
396 } 378 }
OLDNEW
« no previous file with comments | « device/BUILD.gn ('k') | extensions/shell/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698