src/types.cc - Issue 166203002: Handle the uninitialized oddball in Type::LubBitset().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/types.cc

Issue 166203002: Handle the uninitialized oddball in Type::LubBitset(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/types.cc

diff --git a/src/types.cc b/src/types.cc

index 7867899d71de99fe0e9d41df81f4bc234b21e855..3840e6fd223f72c0210b49a386e3ca4462ef4a0b 100644

--- a/src/types.cc

+++ b/src/types.cc

@@ -164,6 +164,7 @@ int TypeImpl<Config>::LubBitset(i::Object* value) {

if (value->IsNull()) return kNull;

if (value->IsBoolean()) return kBoolean;

if (value->IsTheHole()) return kAny; // TODO(rossberg): kNone?

+ if (value->IsUninitialized()) return kNone;

UNREACHABLE();

}

return LubBitset(map);

« no previous file with comments | « no previous file | no next file » | no next file with comments »