Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1662013002: Remove some dead NPAPI code after r363119. (Closed)

Created:
4 years, 10 months ago by jam
Modified:
4 years, 10 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some dead NPAPI code after r363119. The motivation is to remove longs in IPC messages, since they're not safe to send between 32 and 64 bit processes. Although these specific messages weren't used on Android, they block us from having checks against this. BUG=493212, 581409 Committed: https://crrev.com/53531842e932b33169a24286465c44213001aa40 Cr-Commit-Position: refs/heads/master@{#373369}

Patch Set 1 #

Patch Set 2 : remove unused functions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -946 lines) Patch
M content/child/multipart_response_delegate.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/child/multipart_response_delegate.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M content/child/multipart_response_delegate_unittest.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M content/child/npapi/webplugin.h View 2 chunks +0 lines, -15 lines 0 comments Download
M content/child/plugin_messages.h View 4 chunks +0 lines, -52 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.h View 2 chunks +0 lines, -8 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 2 chunks +0 lines, -54 lines 0 comments Download
M content/plugin/webplugin_proxy.h View 6 chunks +0 lines, -16 lines 0 comments Download
M content/plugin/webplugin_proxy.cc View 6 chunks +0 lines, -49 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 6 chunks +0 lines, -98 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.h View 7 chunks +0 lines, -84 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 1 10 chunks +1 line, -458 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jam
4 years, 10 months ago (2016-02-03 18:33:45 UTC) #2
Will Harris
lgtm
4 years, 10 months ago (2016-02-03 22:01:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662013002/20001
4 years, 10 months ago (2016-02-03 22:16:55 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-03 22:47:37 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 22:48:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/53531842e932b33169a24286465c44213001aa40
Cr-Commit-Position: refs/heads/master@{#373369}

Powered by Google App Engine
This is Rietveld 408576698