Modify skia serve to return clip rect and view matrix

Modify skia serve to return clip rect and view matrix

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1662003002

Committed: https://skia.googlesource.com/skia/+/29e5a8932d7dae782f2e58d312a038f8888dab30

[joshua.litt, 2016-02-03 17:29:47]

Description was changed from

==========
Modify skia serve to return clip rect and view matrix

BUG=skia:
==========

to

==========
Modify skia serve to return clip rect and view matrix

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-02-03 17:30:37]

joshualitt@google.com changed reviewers:
+ ethannicholas@google.com, jcgregorio@google.com, joshualitt@google.com

[joshualitt, 2016-02-03 17:30:38]

For some reason this doesn't show up in the info box, but it does work in curl

[jcgregorio, 2016-02-03 19:59:53]

LGTM, modulo a fix for the trailing 0 char.

https://codereview.chromium.org/1662003002/diff/1/tools/skiaserve/skiaserve.cpp
File tools/skiaserve/skiaserve.cpp (right):

https://codereview.chromium.org/1662003002/diff/1/tools/skiaserve/skiaserve.c...
tools/skiaserve/skiaserve.cpp:396: request->fDebugCanvas->drawTo(canvas, n);
Yeah, I think caching the matrix and clip for /info/N calls will be needed in
the future, since we'll be rendering the skp twice for each step as we move
through the commands. Maybe just add a TODO for now?

[joshualitt, 2016-02-04 13:41:37]

https://codereview.chromium.org/1662003002/diff/1/tools/skiaserve/skiaserve.cpp
File tools/skiaserve/skiaserve.cpp (right):

https://codereview.chromium.org/1662003002/diff/1/tools/skiaserve/skiaserve.c...
tools/skiaserve/skiaserve.cpp:396: request->fDebugCanvas->drawTo(canvas, n);
On 2016/02/03 19:59:53, jcgregorio wrote:
> Yeah, I think caching the matrix and clip for /info/N calls will be needed in
> the future, since we'll be rendering the skp twice for each step as we move
> through the commands. Maybe just add a TODO for now?

Acknowledged.

[joshualitt, 2016-02-04 13:41:39]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2016-02-04 13:41:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcgregorio@google.com
Link to the patchset: https://codereview.chromium.org/1662003002/#ps40001
(title: "todo")

[commit-bot: I haz the power, 2016-02-04 13:41:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1662003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1662003002/40001

[commit-bot: I haz the power, 2016-02-04 14:08:36]

Description was changed from

==========
Modify skia serve to return clip rect and view matrix

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Modify skia serve to return clip rect and view matrix

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/29e5a8932d7dae782f2e58d312a038f8888dab30
==========

[commit-bot: I haz the power, 2016-02-04 14:08:37]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/29e5a8932d7dae782f2e58d312a038f8888dab30