Issue 166193002: Setuid sandbox: exit(2) on SIGABRT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 166193002: Setuid sandbox: exit(2) on SIGABRT (Closed)

Created:
6 years, 10 months ago by jln (very slow on Chromium)

Modified:
6 years, 10 months ago

Reviewers:
Jorge Lucangeli Obes

CC:
chromium-reviews, agl, jln+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Setuid sandbox: exit(2) on SIGABRT The setuid sandbox waits on its one child and then dies afterwards. When receiving SIGABRT, instead of dumping core, simply exit the process. There is no interesting information to be gathered from knowing that the process is inside waitid(2), one should look at the child process instead. This patch is in hope to reduce red herrings. BUG=334345 TBR=jorgelo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251271

Patch Set 1 #

Patch Set 2 : Ignore write(2) return value. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	sandbox/linux/suid/sandbox.c	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jln (very slow on Chromium)

Committed patchset #2 manually as r251271 (tree was closed).

6 years, 10 months ago (2014-02-14 07:37:40 UTC) #1

wibling-chromium

A revert of this CL has been created in https://codereview.chromium.org/166253003/ by wibling@chromium.org. The reason for ...

6 years, 10 months ago (2014-02-14 09:14:48 UTC) #2

jln (very slow on Chromium)

6 years, 10 months ago (2014-02-14 17:52:40 UTC) #3

Message was sent while issue was closed.

On 2014/02/14 09:14:48, wibling-chromium wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/166253003/ by mailto:wibling@chromium.org.
> 
> The reason for reverting is: Broke the non-layout linux_tests compile..

Do you have a link to this failure? I can't find anything. Which bot was it?

Expand Messages | Collapse Messages