[counters] adding more counters and log-events

[counters] adding more counters and trace-events
V8 tracks already most useful information, but lacks proper tracing scopes
that make it possible to distinguish certain events from each other.
- add trace-scope to track lazy-parsing due to optimization
- add trace-scope to track code optimization

BUG=

Committed: https://crrev.com/8eb09facb527dd74b6441ce5b1c3c17ebd75b232
Cr-Commit-Position: refs/heads/master@{#34002}

[Camillo Bruni, 2016-02-03 10:40:03]

Description was changed from

==========
[counters] adding more counters and log-events
- add trace-scope to track lazy-parsing due to optimization
- add trace-scope to track code optimization

BUG=
==========

to

==========
[counters] adding more counters and log-events
V8 tracks already most useful information, but lacks proper tracing scopes
that make it possible to distinguish certain events from each other.
- add trace-scope to track lazy-parsing due to optimization
- add trace-scope to track code optimization

BUG=
==========

[Camillo Bruni, 2016-02-03 10:40:36]

cbruni@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Camillo Bruni, 2016-02-03 10:40:37]

PTAL, adding some more timer event scopes to properly distinguish certain
events.
thanks

[Michael Starzinger, 2016-02-03 15:36:27]

https://codereview.chromium.org/1661883003/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1661883003/diff/1/src/compiler.cc#newcode902
src/compiler.cc:902: TimerEventScope<TimerEventOptimizeCode>
optimizeCodeTimer(isolate);
nit: s/optimizeCodeTimer/optimize_code_timer/

https://codereview.chromium.org/1661883003/diff/1/src/compiler.cc#newcode932
src/compiler.cc:932: TimerEventScope<TimerEventOptimizeCode>
optimizeCodeTimer(isolate);
nit: s/optimizeCodeTimer/optimize_code_timer/

https://codereview.chromium.org/1661883003/diff/1/src/compiler.cc#newcode1197
src/compiler.cc:1197: TimerEventScope<TimerEventCompileCode> timer(isolate);
This does not cover lazily compiled functions, and I don't see other timer
scopes for this event anywhere else. Is that on purpose?

https://codereview.chromium.org/1661883003/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/1661883003/diff/1/src/deoptimizer.cc#newcode474
src/deoptimizer.cc:474: void Deoptimizer::DeoptimizeFunction(JSFunction*
function) {
nit: What about this entry point?

https://codereview.chromium.org/1661883003/diff/1/src/runtime/runtime-compile...
File src/runtime/runtime-compiler.cc (right):

https://codereview.chromium.org/1661883003/diff/1/src/runtime/runtime-compile...
src/runtime/runtime-compiler.cc:131: TimerEventScope<TimerEventDeoptimizeCode>
timer(isolate);
nit: Please move this down to after the usual runtime function boilerplate, e.g.
to line 134 or further.

[Camillo Bruni, 2016-02-04 17:47:49]

Description was changed from

==========
[counters] adding more counters and log-events
V8 tracks already most useful information, but lacks proper tracing scopes
that make it possible to distinguish certain events from each other.
- add trace-scope to track lazy-parsing due to optimization
- add trace-scope to track code optimization

BUG=
==========

to

==========
[counters] adding more counters and trace-events
V8 tracks already most useful information, but lacks proper tracing scopes
that make it possible to distinguish certain events from each other.
- add trace-scope to track lazy-parsing due to optimization
- add trace-scope to track code optimization

BUG=
==========

[Camillo Bruni, 2016-02-04 17:48:33]

PTAL again, I hope I covered most paths on where we compile code.

https://codereview.chromium.org/1661883003/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1661883003/diff/1/src/compiler.cc#newcode902
src/compiler.cc:902: TimerEventScope<TimerEventOptimizeCode>
optimizeCodeTimer(isolate);
On 2016/02/03 at 15:36:26, Michael Starzinger wrote:
> nit: s/optimizeCodeTimer/optimize_code_timer/

arg, I fall back to easily to camelCase when programming damn Python for
telemetry :D

https://codereview.chromium.org/1661883003/diff/1/src/runtime/runtime-compile...
File src/runtime/runtime-compiler.cc (right):

https://codereview.chromium.org/1661883003/diff/1/src/runtime/runtime-compile...
src/runtime/runtime-compiler.cc:131: TimerEventScope<TimerEventDeoptimizeCode>
timer(isolate);
On 2016/02/03 at 15:36:26, Michael Starzinger wrote:
> nit: Please move this down to after the usual runtime function boilerplate,
e.g. to line 134 or further.

moved.

[Michael Starzinger, 2016-02-09 09:42:43]

LGTM (with disclaimer, see below).

As discussed offline: I am not confident that we covered all entry points into
either compiler or deoptimizer. So these timers are best effort measurements and
we might not account for potentially large chunks of runtime. Especially future
refactoring could further deteriorate measurements. However I do see the benefit
of getting a "rough feel" for the distribution of runtime, so I am fine with
landing as is.

Also I won't comment on compiler.cc any further, which is broken to the point
where covering all paths through it is nearly impossible.

https://codereview.chromium.org/1661883003/diff/20001/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/1661883003/diff/20001/src/deoptimizer.cc#newc...
src/deoptimizer.cc:477: TimerEventScope<TimerEventDeoptimizeCode>
timer(isolate);
nit: Let's keep this "as simple as possible" by moving the scope to the very top
of the function. I am already not trusting that we covered all entry points with
these scopes, so lets at least stick to either keeping the entire entry point in
scope or not at all. Because the next person coming along refactoring this
method will not give a damn about the timer scope and happily add costly
functionality outside the scope.

https://codereview.chromium.org/1661883003/diff/20001/src/deoptimizer.cc#newc...
src/deoptimizer.cc:488: deoptimizer->DoComputeOutputFrames();
As discussed offline: This is also a beefy method that hasn't been covered by a
timer scope. I vote for adding it as well.

[Camillo Bruni, 2016-02-12 13:44:22]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-02-12 13:44:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1661883003/#ps30001
(title: "addressing nit")

[commit-bot: I haz the power, 2016-02-12 13:44:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1661883003/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1661883003/30001

[commit-bot: I haz the power, 2016-02-12 13:50:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 13:50:41]

Try jobs failed on following builders:
  v8_win64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/2841)

[Camillo Bruni, 2016-02-12 14:44:10]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-02-12 14:44:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1661883003/#ps50001
(title: "fixing merge conflict")

[commit-bot: I haz the power, 2016-02-12 14:44:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1661883003/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1661883003/50001

[commit-bot: I haz the power, 2016-02-12 14:54:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 14:54:10]

Try jobs failed on following builders:
  v8_win_compile_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/1...)

[Camillo Bruni, 2016-02-15 10:30:54]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-15 10:31:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1661883003/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1661883003/70001

[commit-bot: I haz the power, 2016-02-15 10:56:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-15 10:56:41]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-02-15 17:27:14]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-02-15 17:27:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1661883003/#ps70001
(title: "fixing compilation issues")

[commit-bot: I haz the power, 2016-02-15 17:27:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1661883003/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1661883003/70001

[commit-bot: I haz the power, 2016-02-15 17:29:26]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2016-02-15 17:29:37]

Description was changed from

==========
[counters] adding more counters and trace-events
V8 tracks already most useful information, but lacks proper tracing scopes
that make it possible to distinguish certain events from each other.
- add trace-scope to track lazy-parsing due to optimization
- add trace-scope to track code optimization

BUG=
==========

to

==========
[counters] adding more counters and trace-events
V8 tracks already most useful information, but lacks proper tracing scopes
that make it possible to distinguish certain events from each other.
- add trace-scope to track lazy-parsing due to optimization
- add trace-scope to track code optimization

BUG=

Committed: https://crrev.com/8eb09facb527dd74b6441ce5b1c3c17ebd75b232
Cr-Commit-Position: refs/heads/master@{#34002}
==========

[commit-bot: I haz the power, 2016-02-15 17:29:37]

Patchset 5 (id:??) landed as
https://crrev.com/8eb09facb527dd74b6441ce5b1c3c17ebd75b232
Cr-Commit-Position: refs/heads/master@{#34002}