Introduce getPrefixEndToken to avoid too big context in messages.

Introduce getPrefixEndToken to avoid too big context in messages.

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/fcad7b6b5b305f2c7ae87b63b70847a25cf39052

[Johnni Winther, 2016-02-04 10:53:56]

johnniwinther@google.com changed reviewers:
+ ahe@google.com

[ahe, 2016-02-04 11:32:33]

lgtm

https://codereview.chromium.org/1661853005/diff/1/pkg/compiler/lib/src/tree/n...
File pkg/compiler/lib/src/tree/nodes.dart (right):

https://codereview.chromium.org/1661853005/diff/1/pkg/compiler/lib/src/tree/n...
pkg/compiler/lib/src/tree/nodes.dart:153: /// start of a class body for a
[ClassNode].
The last token *before* the start of a class body?

https://codereview.chromium.org/1661853005/diff/1/pkg/compiler/lib/src/tree/n...
pkg/compiler/lib/src/tree/nodes.dart:274: return body != null ?
body.getBeginToken() : getEndToken();
How about using the token before body.getBeginToken()?

https://codereview.chromium.org/1661853005/diff/1/tests/compiler/dart2js/mess...
File tests/compiler/dart2js/message_span_test.dart (right):

https://codereview.chromium.org/1661853005/diff/1/tests/compiler/dart2js/mess...
tests/compiler/dart2js/message_span_test.dart:29: ^^^^^^^^^^^^^^^^^^^'''}),
I suggest this becomes:

class B extends A {
^^^^^^^^^^^^^^^^^

[Johnni Winther, 2016-02-05 09:14:20]

PTAL

The changes uncovered a bug in TypeAnnotation.getEndToken()  and the solution
triggered assertion failures..

https://codereview.chromium.org/1661853005/diff/1/pkg/compiler/lib/src/tree/n...
File pkg/compiler/lib/src/tree/nodes.dart (right):

https://codereview.chromium.org/1661853005/diff/1/pkg/compiler/lib/src/tree/n...
pkg/compiler/lib/src/tree/nodes.dart:153: /// start of a class body for a
[ClassNode].
On 2016/02/04 11:32:33, ahe wrote:
> The last token *before* the start of a class body?

Done.

https://codereview.chromium.org/1661853005/diff/1/pkg/compiler/lib/src/tree/n...
pkg/compiler/lib/src/tree/nodes.dart:274: return body != null ?
body.getBeginToken() : getEndToken();
On 2016/02/04 11:32:33, ahe wrote:
> How about using the token before body.getBeginToken()?

Done.

https://codereview.chromium.org/1661853005/diff/1/tests/compiler/dart2js/mess...
File tests/compiler/dart2js/message_span_test.dart (right):

https://codereview.chromium.org/1661853005/diff/1/tests/compiler/dart2js/mess...
tests/compiler/dart2js/message_span_test.dart:29: ^^^^^^^^^^^^^^^^^^^'''}),
On 2016/02/04 11:32:33, ahe wrote:
> I suggest this becomes:
> 
> class B extends A {
> ^^^^^^^^^^^^^^^^^

Done.

[ahe, 2016-02-08 14:40:13]

lgtm

https://codereview.chromium.org/1661853005/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1661853005/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/compiler.dart:1803: return sought.stringValue == '>';
Also look at character offset?

https://codereview.chromium.org/1661853005/diff/20001/pkg/compiler/lib/src/tr...
File pkg/compiler/lib/src/tree/nodes.dart (right):

https://codereview.chromium.org/1661853005/diff/20001/pkg/compiler/lib/src/tr...
pkg/compiler/lib/src/tree/nodes.dart:287: assert(token != null);
assert invariant using beginToken?

[ahe, 2016-02-08 14:41:58]

A thought for future consideration: instead of using real diagnostic messages,
it might be nice to instead lookup elements by "qualified" name and simulate a
message on that element.

This way this test is testing positions independently of specific messages.

[Johnni Winther, 2016-02-09 11:59:58]

https://codereview.chromium.org/1661853005/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1661853005/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/compiler.dart:1803: return sought.stringValue == '>';
On 2016/02/08 14:40:13, ahe wrote:
> Also look at character offset?

Done.

https://codereview.chromium.org/1661853005/diff/20001/pkg/compiler/lib/src/tr...
File pkg/compiler/lib/src/tree/nodes.dart (right):

https://codereview.chromium.org/1661853005/diff/20001/pkg/compiler/lib/src/tr...
pkg/compiler/lib/src/tree/nodes.dart:287: assert(token != null);
On 2016/02/08 14:40:13, ahe wrote:
> assert invariant using beginToken?

Done.

[Johnni Winther, 2016-02-10 08:27:40]

Description was changed from

==========
Introduce getPrefixEndToken to avoid too big context in messages.
==========

to

==========
Introduce getPrefixEndToken to avoid too big context in messages.

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fcad7b6b5b305f2c7ae87b63b70847a25cf39052
==========

[Johnni Winther, 2016-02-10 08:27:42]

Committed patchset #3 (id:40001) manually as
fcad7b6b5b305f2c7ae87b63b70847a25cf39052 (presubmit successful).