Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1661803003: Don't reload an svg <use> element's xlink:href if only the fragment changes (Closed)

Created:
4 years, 10 months ago by Nate Chapin
Modified:
4 years, 10 months ago
Reviewers:
pdr.
CC:
chromium-reviews, krit, kouhei+svg_chromium.org, fs, f(malita), blink-reviews, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't reload an svg <use> element's xlink:href if only the fragment changes BUG=580809 TEST=http/tests/cache/svg-use-revalidate.html Committed: https://crrev.com/332761c7f4da3aa451028a6a3d16aafd607b69be Cr-Commit-Position: refs/heads/master@{#373371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/http/tests/cache/resources/.htaccess View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/cache/resources/circles-no-cache.svg View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/cache/svg-use-revalidate.html View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/cache/svg-use-revalidate-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Nate Chapin
It appears that any time a svg <use> element's href changed, we used to re-request ...
4 years, 10 months ago (2016-02-03 20:55:30 UTC) #2
pdr.
On 2016/02/03 at 20:55:30, japhet wrote: > It appears that any time a svg <use> ...
4 years, 10 months ago (2016-02-03 21:02:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661803003/1
4 years, 10 months ago (2016-02-03 21:41:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 22:49:10 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 22:50:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/332761c7f4da3aa451028a6a3d16aafd607b69be
Cr-Commit-Position: refs/heads/master@{#373371}

Powered by Google App Engine
This is Rietveld 408576698