Centralize all gbm ozone host IPC

Centralize all gbm ozone host IPC

Introduce a GpuThreadAdapter and implement it in the
DrmGpuPlatformSupportHost to complete making host to GPU communication
be pluggable and hence easily support traditional IPC, operation in
MUS or Mojo IPC.

BUG=558602
Committed: https://crrev.com/8471a0a9e42cde08421463086aa1219548e5451a
Cr-Commit-Position: refs/heads/master@{#373593}

[rjkroege, 2016-02-03 01:03:29]

rjkroege@chromium.org changed reviewers:
+ dnicoara@chromium.org

[rjkroege, 2016-02-03 01:03:30]

PTAL

[dnicoara, 2016-02-03 14:54:30]

lgtm with some minor nits.

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_display_host.cc (right):

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_display_host.cc:10: #include
"ui/ozone/common/gpu/ozone_gpu_messages.h"
nit: You may want to remove this include since you won't be including this for
MUS. (Though this can be done later too).

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_display_host_manager.cc (right):

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_display_host_manager.cc:22: #include
"ui/ozone/common/gpu/ozone_gpu_messages.h"
nit: Maybe remove this include.

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h (right):

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h:38: //  void
RegisterHandler(GpuPlatformSupportHost* handler);
nit: Remove these.

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h:41: void
AddGpuThreadObserver(GpuThreadObserver* observer) override;
nit: Could you move these with the other functions under "GpuThreadAdapter:" so
it is obvious what interface they're coming from.

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h:116:
DrmDisplayHostManager* host_manager_;  // Not owned.
nit: Could this be display_host_manager_ or even display_manager_? It'd be more
explicit.

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_overlay_manager.cc (right):

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_overlay_manager.cc:13: #include
"ui/ozone/common/gpu/ozone_gpu_messages.h"
nit: Maybe remove this include.

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_window_host.cc (right):

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_window_host.cc:14: #include
"ui/ozone/common/gpu/ozone_gpu_messages.h"
nit: Maybe remove this include.

[rjkroege, 2016-02-04 00:09:40]

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_display_host.cc (right):

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_display_host.cc:10: #include
"ui/ozone/common/gpu/ozone_gpu_messages.h"
On 2016/02/03 14:54:29, dnicoara wrote:
> nit: You may want to remove this include since you won't be including this for
> MUS. (Though this can be done later too).

Done.

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_display_host_manager.cc (right):

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_display_host_manager.cc:22: #include
"ui/ozone/common/gpu/ozone_gpu_messages.h"
On 2016/02/03 14:54:29, dnicoara wrote:
> nit: Maybe remove this include.

Done.

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h (right):

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h:38: //  void
RegisterHandler(GpuPlatformSupportHost* handler);
On 2016/02/03 14:54:30, dnicoara wrote:
> nit: Remove these.

Done.

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h:41: void
AddGpuThreadObserver(GpuThreadObserver* observer) override;
On 2016/02/03 14:54:30, dnicoara wrote:
> nit: Could you move these with the other functions under "GpuThreadAdapter:"
so
> it is obvious what interface they're coming from.

Done.

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h:116:
DrmDisplayHostManager* host_manager_;  // Not owned.
On 2016/02/03 14:54:30, dnicoara wrote:
> nit: Could this be display_host_manager_ or even display_manager_? It'd be
more
> explicit.

Done.

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_overlay_manager.cc (right):

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_overlay_manager.cc:13: #include
"ui/ozone/common/gpu/ozone_gpu_messages.h"
On 2016/02/03 14:54:30, dnicoara wrote:
> nit: Maybe remove this include.

Done.

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_window_host.cc (right):

https://codereview.chromium.org/1661783002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_window_host.cc:14: #include
"ui/ozone/common/gpu/ozone_gpu_messages.h"
On 2016/02/03 14:54:30, dnicoara wrote:
> nit: Maybe remove this include.

Done.

[rjkroege, 2016-02-04 00:10:29]

rjkroege@chromium.org changed reviewers:
+ jam@chromium.org

[rjkroege, 2016-02-04 00:10:30]

+jam for pre-submit change. (Renamed a file with existing blocking I/O
exemption.)

[jam, 2016-02-04 19:03:13]

lgtm

[rjkroege, 2016-02-04 19:03:49]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-02-04 19:03:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
dnicoara@chromium.org
Link to the patchset: https://codereview.chromium.org/1661783002/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2016-02-04 19:05:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1661783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1661783002/40001

[commit-bot: I haz the power, 2016-02-04 19:50:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-04 19:51:53]

Description was changed from

==========
Centralize all gbm ozone host IPC

Introduce a GpuThreadAdapter and implement it in the
DrmGpuPlatformSupportHost to complete making host to GPU communication
be pluggable and hence easily support traditional IPC, operation in
MUS or Mojo IPC.

BUG=558602
==========

to

==========
Centralize all gbm ozone host IPC

Introduce a GpuThreadAdapter and implement it in the
DrmGpuPlatformSupportHost to complete making host to GPU communication
be pluggable and hence easily support traditional IPC, operation in
MUS or Mojo IPC.

BUG=558602

Committed: https://crrev.com/8471a0a9e42cde08421463086aa1219548e5451a
Cr-Commit-Position: refs/heads/master@{#373593}
==========

[commit-bot: I haz the power, 2016-02-04 19:51:53]

Patchset 3 (id:??) landed as
https://crrev.com/8471a0a9e42cde08421463086aa1219548e5451a
Cr-Commit-Position: refs/heads/master@{#373593}