Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1661713003: [wasm] Rename local_int32_count to local_i32_count and similar textual replacements. (Closed)

Created:
4 years, 10 months ago by titzer
Modified:
4 years, 10 months ago
Reviewers:
ahaas, JF
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Rename local_int32_count to local_i32_count and similar textual replacements. R=ahaas@chromium.org,jfb@chromium.org BUG= Committed: https://crrev.com/007e14ce4ba444531e9ec27b3e2a760f80cb801c Cr-Commit-Position: refs/heads/master@{#33702}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -131 lines) Patch
M src/compiler/wasm-compiler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/wasm/ast-decoder.h View 2 chunks +19 lines, -19 lines 0 comments Download
M src/wasm/ast-decoder.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M src/wasm/encoder.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/wasm/encoder.cc View 2 chunks +24 lines, -24 lines 0 comments Download
M src/wasm/module-decoder.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +4 lines, -8 lines 1 comment Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +4 lines, -4 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M test/unittests/wasm/encoder-unittest.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M test/unittests/wasm/loop-assignment-analysis-unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 5 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
4 years, 10 months ago (2016-02-03 10:33:07 UTC) #1
JF
lgtm assuming sed-fu prevented mis-substituting, and none were forgotten! https://codereview.chromium.org/1661713003/diff/1/src/wasm/wasm-module.cc File src/wasm/wasm-module.cc (right): https://codereview.chromium.org/1661713003/diff/1/src/wasm/wasm-module.cc#newcode40 src/wasm/wasm-module.cc:40: ...
4 years, 10 months ago (2016-02-03 10:36:33 UTC) #2
titzer
On 2016/02/03 10:36:33, JF wrote: > lgtm assuming sed-fu prevented mis-substituting, and none were forgotten! ...
4 years, 10 months ago (2016-02-03 11:03:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661713003/1
4 years, 10 months ago (2016-02-03 11:04:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 11:06:01 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 11:06:55 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/007e14ce4ba444531e9ec27b3e2a760f80cb801c
Cr-Commit-Position: refs/heads/master@{#33702}

Powered by Google App Engine
This is Rietveld 408576698