Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: tools/testing/dart/runtime_configuration.dart

Issue 1661703002: VM: Replace dart --noopt with new binary target dart_noopt. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/runtime_configuration.dart
diff --git a/tools/testing/dart/runtime_configuration.dart b/tools/testing/dart/runtime_configuration.dart
index 2978003369e1da3c254d781943598e26674161c0..19fcdda982198a3b576f0d2326a25653d6898027 100644
--- a/tools/testing/dart/runtime_configuration.dart
+++ b/tools/testing/dart/runtime_configuration.dart
@@ -218,8 +218,11 @@ class StandaloneDartRuntimeConfiguration extends DartVmRuntimeConfiguration {
if (script != null && type != 'application/dart') {
throw "Dart VM cannot run files of type '$type'.";
}
+ String executable = suite.configuration['noopt']
+ ? suite.dartVmNooptBinaryFileName
+ : suite.dartVmBinaryFileName;
return <Command>[commandBuilder.getVmCommand(
- suite.dartVmBinaryFileName, arguments, environmentOverrides)];
+ executable, arguments, environmentOverrides)];
}
}
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698