Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1661703002: VM: Replace dart --noopt with new binary target dart_noopt. (Closed)

Created:
4 years, 10 months ago by Florian Schneider
Modified:
4 years, 10 months ago
Reviewers:
rmacnak, Ivan Posva
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Replace dart --noopt with new binary target dart_noopt. This allows us to exclude precompiler related code from the standalone JIT VM, and only have the precompiler included in dart_noopt and dart_no_snapshot (which is used to generate precompiled snapshots) BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/0f48690061e3f7d6214fe5f81310430e641a3ecd

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -27 lines) Patch
M dart.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/bin.gypi View 1 3 chunks +63 lines, -0 lines 0 comments Download
M runtime/bin/main.cc View 3 chunks +10 lines, -14 lines 0 comments Download
M runtime/dart-runtime.gyp View 2 chunks +36 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/vm.gypi View 2 chunks +64 lines, -0 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 4 chunks +3 lines, -9 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
I reused the old name dart_noopt for consistency, but am open for other suggestions.
4 years, 10 months ago (2016-02-02 21:45:37 UTC) #2
rmacnak
lgtm https://chromiumcodereview.appspot.com/1661703002/diff/1/runtime/bin/bin.gypi File runtime/bin/bin.gypi (right): https://chromiumcodereview.appspot.com/1661703002/diff/1/runtime/bin/bin.gypi#newcode822 runtime/bin/bin.gypi:822: 'defines': [ + DART_NO_SNAPSHOT https://chromiumcodereview.appspot.com/1661703002/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): ...
4 years, 10 months ago (2016-02-02 22:38:56 UTC) #3
Florian Schneider
https://codereview.chromium.org/1661703002/diff/1/runtime/bin/bin.gypi File runtime/bin/bin.gypi (right): https://codereview.chromium.org/1661703002/diff/1/runtime/bin/bin.gypi#newcode822 runtime/bin/bin.gypi:822: 'defines': [ On 2016/02/02 22:38:56, rmacnak wrote: > + ...
4 years, 10 months ago (2016-02-03 01:25:43 UTC) #4
Florian Schneider
4 years, 10 months ago (2016-02-03 01:51:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
0f48690061e3f7d6214fe5f81310430e641a3ecd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698