chrome/browser/ui/views/toolbar/toolbar_action_view.h - Issue 1661673004: Enables hot-tracking for overflow extension buttons in the app menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.h

Issue 1661673004: Enables hot-tracking for overflow extension buttons in the app menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restores hot-tracking of extension buttons in app menu with MD (tests) Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/toolbar/app_menu.cc ('K') | « chrome/browser/ui/views/toolbar/app_menu.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_action_view.cc » ('j') | ui/views/controls/menu/menu_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/toolbar_action_view.h

diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.h b/chrome/browser/ui/views/toolbar/toolbar_action_view.h

index 399ea3d488c4c313ccaa6cf113bd255d53715226..613dbf4dcf53a4c020125d87049dd555408d807d 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.h

+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.h

@@ -78,6 +78,7 @@ class ToolbarActionView : public views::MenuButton,

bool IsTriggerableEvent(const ui::Event& event) override;

void AddInkDropLayer(ui::Layer* ink_drop_layer) override;

void RemoveInkDropLayer(ui::Layer* ink_drop_layer) override;

+ bool ShouldShowInkDropHover() const override;

// ToolbarActionViewDelegateViews:

content::WebContents* GetCurrentWebContents() const override;