ui/views/controls/menu/menu_scroll_view_container.cc - Issue 1661673004: Enables hot-tracking for overflow extension buttons in the app menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_scroll_view_container.cc

Issue 1661673004: Enables hot-tracking for overflow extension buttons in the app menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restores hot-tracking of extension buttons in app menu with MD (default ctor for ExtraParams) Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/menu/menu_scroll_view_container.cc

diff --git a/ui/views/controls/menu/menu_scroll_view_container.cc b/ui/views/controls/menu/menu_scroll_view_container.cc

index 05c8caedb5505b4ac7c596195ec5d4aa02a4f7f0..c25f9062db669a656ae989ca02f7ae452a0eb13d 100644

--- a/ui/views/controls/menu/menu_scroll_view_container.cc

+++ b/ui/views/controls/menu/menu_scroll_view_container.cc

@@ -76,7 +76,6 @@ class MenuScrollButton : public View {

// The background.

gfx::Rect item_bounds(0, 0, width(), height());

NativeTheme::ExtraParams extra;

- extra.menu_item.is_selected = false;

GetNativeTheme()->Paint(canvas->sk_canvas(),

NativeTheme::kMenuItemBackground,

NativeTheme::kNormal, item_bounds, extra);

« ui/native_theme/native_theme.h ('K') | « ui/views/controls/menu/menu_controller.cc ('k') | no next file » | no next file with comments »