Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1661643002: [Line Layout API] Convert more references in BlockPainter to new line layout API (Closed)

Created:
4 years, 10 months ago by pilgrim_google
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dgrogan, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Line Layout API] Convert more references in BlockPainter to new line layout API Classes outside of core/layout/ that need a reference to an InlineBox's layoutObject must currently use the API-busting shim we've set up to get a reference to a LineLayoutItem's underlying layoutObject. Some references can simply be changed to lineLayoutItem() directly, where the line layout API already provides access to the methods used. There are no functional changes. BUG=499321 TBR=leviw Committed: https://crrev.com/7ab76ad1fbc24cd8486e0485e617c1a338c747ea Cr-Commit-Position: refs/heads/master@{#373075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
pilgrim_google
4 years, 10 months ago (2016-02-02 21:24:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661643002/1
4 years, 10 months ago (2016-02-02 21:25:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 23:47:18 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7ab76ad1fbc24cd8486e0485e617c1a338c747ea Cr-Commit-Position: refs/heads/master@{#373075}
4 years, 10 months ago (2016-02-02 23:48:33 UTC) #8
leviw_travelin_and_unemployed
4 years, 10 months ago (2016-02-03 00:03:57 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698