Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 166163007: Remove --ui-enable-software-compositing flag. (Closed)

Created:
6 years, 10 months ago by danakj
Modified:
6 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, Ian Vollick, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org, jbauman
Visibility:
Public.

Description

Remove --ui-enable-software-compositing flag. This flag is redundant with --disable-gpu which causes us to fall into software compositing mode. Depends on: https://codereview.chromium.org/167973003/ R=piman@chromium.org, piman BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252093

Patch Set 1 #

Patch Set 2 : uienablesoftwarecompositing: #

Patch Set 3 : uienablesoftwarecompositing: #

Patch Set 4 : uienablesoftwarecompositing: #

Patch Set 5 : uienablesoftwarecompositing: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M content/browser/compositor/gpu_process_transport_factory.cc View 1 2 3 1 chunk +8 lines, -13 lines 0 comments Download
M content/public/test/browser_test_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor_switches.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
Also cleaned up GpuProcessTransportFactory so we only have to look at one bool to decide ...
6 years, 10 months ago (2014-02-15 00:33:24 UTC) #1
piman
lgtm
6 years, 10 months ago (2014-02-15 00:53:34 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-19 17:09:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/166163007/90001
6 years, 10 months ago (2014-02-19 17:12:59 UTC) #4
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-19 21:13:04 UTC) #5
danakj
6 years, 10 months ago (2014-02-19 21:15:12 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 manually as r252093 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698