Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: Source/core/dom/Element.h

Issue 166163005: [SVG2] Add tabindex handling in svg. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/repaint/focus-element.html ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Element.h
diff --git a/Source/core/dom/Element.h b/Source/core/dom/Element.h
index dfba38b758b5054691eb02ad7e8562277536526a..3ae0445f65f5a71b3dee3cc736a56c83e0d4799d 100644
--- a/Source/core/dom/Element.h
+++ b/Source/core/dom/Element.h
@@ -291,7 +291,7 @@ public:
// This method is called whenever an attribute is added, changed or removed.
virtual void attributeChanged(const QualifiedName&, const AtomicString&, AttributeModificationReason = ModifiedDirectly);
- virtual void parseAttribute(const QualifiedName&, const AtomicString&) { }
+ virtual void parseAttribute(const QualifiedName&, const AtomicString&);
virtual bool hasLegalLinkAttribute(const QualifiedName&) const;
virtual const QualifiedName& subResourceAttributeName() const;
@@ -374,7 +374,7 @@ public:
// focusable but some elements, such as form controls and links, are. Unlike
// rendererIsFocusable(), this method may be called when layout is not up to
// date, so it must not use the renderer to determine focusability.
- virtual bool supportsFocus() const { return hasElementFlag(TabIndexWasSetExplicitly); }
+ virtual bool supportsFocus() const;
// Whether the node can actually be focused.
bool isFocusable() const;
virtual bool isKeyboardFocusable() const;
@@ -510,6 +510,9 @@ public:
MutableStylePropertySet& ensureMutableInlineStyle();
void clearMutableInlineStyleIfEmpty();
+ void setTabIndex(int);
+ virtual short tabIndex() const OVERRIDE;
+
protected:
Element(const QualifiedName& tagName, Document* document, ConstructionType type)
: ContainerNode(document, type)
@@ -533,9 +536,10 @@ protected:
virtual bool shouldRegisterAsNamedItem() const { return false; }
virtual bool shouldRegisterAsExtraNamedItem() const { return false; }
+ virtual bool supportsSpatialNavigationFocus() const;
+
void clearTabIndexExplicitlyIfNeeded();
void setTabIndexExplicitly(short);
- virtual short tabIndex() const OVERRIDE;
// Subclasses may override this method to affect focusability. Unlike
// supportsFocus, this method must be called on an up-to-date layout, so it
// may use the renderer to reason about focusability. This method cannot be
« no previous file with comments | « LayoutTests/svg/repaint/focus-element.html ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698