Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 166163003: Add flags for write barrier elimination and local allocation folding. (Closed)

Created:
6 years, 10 months ago by Michael Starzinger
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add flags for write barrier elimination and local allocation folding. R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19382

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment by Hannes Payer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/flag-definitions.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
6 years, 10 months ago (2014-02-14 10:34:17 UTC) #1
Hannes Payer (out of office)
LGTM, one nit https://codereview.chromium.org/166163003/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/166163003/diff/1/src/flag-definitions.h#newcode255 src/flag-definitions.h:255: DEFINE_bool(use_write_barrier_elimination, true, "eliminate write barriers") We ...
6 years, 10 months ago (2014-02-14 12:02:52 UTC) #2
Michael Starzinger
Comments addressed. Landing. https://codereview.chromium.org/166163003/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/166163003/diff/1/src/flag-definitions.h#newcode255 src/flag-definitions.h:255: DEFINE_bool(use_write_barrier_elimination, true, "eliminate write barriers") On ...
6 years, 10 months ago (2014-02-14 14:37:34 UTC) #3
Michael Starzinger
6 years, 10 months ago (2014-02-14 14:58:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19382 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698