Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 1661623002: [Media Router] Fix regression with icon not turning blue after casting. (Closed)

Created:
4 years, 10 months ago by imcheng
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

[Media Router] Fix regression with icon not turning blue after casting. Previously MR relies on the behavior of route response returning a local displayable route on success. This is no longer the case, thus the logic to turn the toolbar icon blue is no longer getting triggered. The fix is to have the toolbar observe route list directly for local displayable routes. Route queries have a much lower overhead than before. In a separate patch we will clean up the now obsolete LocalMediaRoutesObserver API from MR and MR extension. BUG=582278 Review URL: https://codereview.chromium.org/1648713004 Cr-Commit-Position: refs/heads/master@{#372750} (cherry picked from commit 7f297c082c6be8d8495c5b4fe22069e93ed92a73) Committed: https://chromium.googlesource.com/chromium/src/+/1fb5ee6a720f4480cfe013fd60b5f48cf46d7de3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -25 lines) Patch
M chrome/browser/ui/toolbar/media_router_action.h View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/media_router_action.cc View 3 chunks +19 lines, -14 lines 0 comments Download
M chrome/browser/ui/toolbar/media_router_action_unittest.cc View 8 chunks +41 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
imcheng
4 years, 10 months ago (2016-02-02 20:26:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1fb5ee6a720f4480cfe013fd60b5f48cf46d7de3.

Powered by Google App Engine
This is Rietveld 408576698