Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 166153002: [SyncFS] Check MetadataDatabase availability before database operation (Closed)

Created:
6 years, 10 months ago by tzik
Modified:
6 years, 10 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, kinuko+watch, nhiroki, tzik
Visibility:
Public.

Description

[SyncFS] Check MetadataDatabase availability before database operation This should fix NULL pointer access failure on app reload. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251324

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 1 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tzik
PTL
6 years, 10 months ago (2014-02-14 06:54:54 UTC) #1
nhiroki
lgtm
6 years, 10 months ago (2014-02-14 07:17:06 UTC) #2
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 10 months ago (2014-02-14 07:50:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/166153002/60001
6 years, 10 months ago (2014-02-14 07:50:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 10:46:02 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264163
6 years, 10 months ago (2014-02-14 10:46:03 UTC) #6
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 10 months ago (2014-02-14 11:51:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/166153002/60001
6 years, 10 months ago (2014-02-14 11:51:51 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 15:11:40 UTC) #9
Message was sent while issue was closed.
Change committed as 251324

Powered by Google App Engine
This is Rietveld 408576698