third_party/WebKit/Source/core/layout/FloatingObjects.h - Issue 1661523002: Update should paint flag when a float's composited scrolling status changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/FloatingObjects.h

Issue 1661523002: Update should paint flag when a float's composited scrolling status changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/block/float/float-change-composited-scrolling.html ('K') | « third_party/WebKit/LayoutTests/fast/block/float/float-change-composited-scrolling-expected.html ('k') | third_party/WebKit/Source/core/layout/LayoutBlockFlow.h » ('j') | third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/FloatingObjects.h

diff --git a/third_party/WebKit/Source/core/layout/FloatingObjects.h b/third_party/WebKit/Source/core/layout/FloatingObjects.h

index 0fe4c6ef9b780f8d658c5f094b632a76648eaa22..d9d597c82a5d0d34fee60d3ef1e9a1c9a54cbc4c 100644

--- a/third_party/WebKit/Source/core/layout/FloatingObjects.h

+++ b/third_party/WebKit/Source/core/layout/FloatingObjects.h

@@ -151,6 +151,7 @@ public:

bool hasLeftObjects() const { return m_leftObjectsCount > 0; }

bool hasRightObjects() const { return m_rightObjectsCount > 0; }

const FloatingObjectSet& set() const { return m_set; }

+ FloatingObjectSet& set() { return m_set; }

wkorman 2016/02/02 22:02:35 Perhaps name this mutableSet() to more explicitly

Xianzhu 2016/02/02 22:47:12 Good point. Done.

void clearLineBoxTreePointers();

LayoutUnit logicalLeftOffset(LayoutUnit fixedOffset, LayoutUnit logicalTop, LayoutUnit logicalHeight);