third_party/WebKit/LayoutTests/fast/block/float/float-change-composited-scrolling.html - Issue 1661523002: Update should paint flag when a float's composited scrolling status changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/block/float/float-change-composited-scrolling.html

Issue 1661523002: Update should paint flag when a float's composited scrolling status changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/block/float/float-change-composited-scrolling-expected.html » ('j') | third_party/WebKit/Source/core/layout/FloatingObjects.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/run-after-layout-and-paint.js"></script>

	3 <script>

	4 if (window.internals) {

	5 internals.settings.setPreferCompositingToLCDTextEnabled(true);

	6 internals.settings.setMockScrollbarsEnabled(true);

	7 internals.settings.setOverlayScrollbarsEnabled(true);

	8 }

	9

	10 if (window.testRunner)

	11 testRunner.waitUntilDone();

	12

	13 runAfterLayoutAndPaint(function() {

	14 document.getElementById('content').style.height = '250px';

	15 runAfterLayoutAndPaint(function() {

	16 document.getElementById('content').style.height = '150px';

	17 if (window.testRunner)
	wkorman 2016/02/02 22:02:35 I think you can just pass true as a second param t I think you can just pass true as a second param to this call to runAfterLayoutAndPaint() and omit this and next two lines. Xianzhu 2016/02/02 22:47:12 Done. Actually there was a syntax error here. Add Show quoted text On 2016/02/02 22:02:35, wkorman wrote: > I think you can just pass true as a second param to this call to > runAfterLayoutAndPaint() and omit this and next two lines. Done. Actually there was a syntax error here. Added logic to ensure the test finishes.
	18 testRunner.notifyDone();

	19 };

	20 });

	21 </script>

	22

	23 Tests a float changes using composited scrolling. Passes if the green square is always visible.<p>

	24 To test manually, use command line switches --enable-prefer-compositing-to-lcd-t ext --enable-overlay-scrollbar

	25 <div style="height: 200px">

	26 <div style="float: left; width: 300px; height: 100%; overflow: auto; backgroun d-color: green">

	27 <div id="content" style="height: 150px"></div>

	28 </div>

	29 </div>

OLD	NEW