third_party/WebKit/Source/modules/mediastream/MediaErrorState.h - Issue 1661493002: Add promise-based addIceCandidate, setLocalDescription and setRemoteDescription to RTCPeerConnection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/MediaErrorState.h

Issue 1661493002: Add promise-based addIceCandidate, setLocalDescription and setRemoteDescription to RTCPeerConnection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use ScriptPromiseResolver::detach() to leave the promise unresolved. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html ('K') | « third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription-promise-expected.txt ('k') | third_party/WebKit/Source/modules/mediastream/MediaErrorState.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/MediaErrorState.h

diff --git a/third_party/WebKit/Source/modules/mediastream/MediaErrorState.h b/third_party/WebKit/Source/modules/mediastream/MediaErrorState.h

index cd07d670e17016eddc177b57addd9dce4dea0de1..eaf782fbc0e1224a390873e6f2cae2cc882619e6 100644

--- a/third_party/WebKit/Source/modules/mediastream/MediaErrorState.h

+++ b/third_party/WebKit/Source/modules/mediastream/MediaErrorState.h

@@ -39,7 +39,7 @@ class NavigatorUserMediaError;

// A class that is able to be used like ExceptionState for carrying

// information about an error up the stack, but it is up to the higher

-// level code whether it produces a DOMerror or a NavigatorUserMediaError.

+// level code whether it produces a DOMException or a NavigatorUserMediaError.

class MediaErrorState {

public:

MediaErrorState();

@@ -51,12 +51,13 @@ public:

bool hadException();

bool canGenerateException();

void raiseException(ExceptionState&);

+ String getErrorMessage();

NavigatorUserMediaError* createError();

private:

enum ErrorType {

NoError,

TypeError,

- DOMError,

+ DOMException,

ConstraintError

};

ErrorType m_errorType;