Add promise-based addIceCandidate, setLocalDescription and setRemoteDescription to RTCPeerConnection

third_party/WebKit/Source/modules/mediastream/RTCVoidRequestPromiseImpl.cpp

Index: third_party/WebKit/Source/modules/mediastream/RTCVoidRequestPromiseImpl.cpp
diff --git a/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestPromiseImpl.cpp b/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestPromiseImpl.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..18213ef79c0756092040ab663dc5ff6ce4c1bc2b
--- /dev/null
+++ b/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestPromiseImpl.cpp
@@ -0,0 +1,71 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "modules/mediastream/RTCVoidRequestPromiseImpl.h"
+
+#include "bindings/core/v8/ScriptPromiseResolver.h"
+#include "core/dom/DOMException.h"
+#include "modules/mediastream/RTCPeerConnection.h"
+
+namespace blink {
+
+RTCVoidRequestPromiseImpl* RTCVoidRequestPromiseImpl::create(RTCPeerConnection* requester, ScriptPromiseResolver* resolver, ExceptionCode exceptionCode)
+{
+    RTCVoidRequestPromiseImpl* request = new RTCVoidRequestPromiseImpl(requester, resolver, exceptionCode);
+    return request;
+}
+
+RTCVoidRequestPromiseImpl::RTCVoidRequestPromiseImpl(RTCPeerConnection* requester, ScriptPromiseResolver* resolver, ExceptionCode exceptionCode)
+    : m_requester(requester)
+    , m_resolver(resolver)
+    , m_exceptionCode(exceptionCode)
+{
+    ASSERT(m_requester);
+    ASSERT(m_resolver);
+    m_resolver->keepAliveWhilePending();

[yhirano, 2016/02/11 23:32:50]

Sorry I didn't notice this before, but is this call needed? If the
RTCVoidRequestPromiseImpl is properly kept alive, you don't need to call this
function.

[Guido Urdaneta, 2016/02/12 09:30:55]

I wasn't completely sure it was needed. Removed now.

+}
+
+RTCVoidRequestPromiseImpl::~RTCVoidRequestPromiseImpl()
+{
+}
+
+void RTCVoidRequestPromiseImpl::requestSucceeded()
+{
+    if (m_requester && m_requester->shouldFireDefaultCallbacks()) {
+        m_resolver->resolve();
+    } else {
+        // This is needed to have the resolver release its internal resources
+        // while leaving the associated promise pending as specified".

[yhirano, 2016/02/11 23:32:50]

You don't need the last double quotation.

[Guido Urdaneta, 2016/02/12 09:30:55]

Done.

+        m_resolver->stop();
+    }
+
+    clear();
+}
+
+void RTCVoidRequestPromiseImpl::requestFailed(const String& error)
+{
+    if (m_requester && m_requester->shouldFireDefaultCallbacks()) {
+        m_resolver->reject(DOMException::create(m_exceptionCode, error));
+    } else {
+        // This is needed to have the resolver release its internal resources
+        // while leaving the associated promise pending as specified".
+        m_resolver->stop();
+    }
+
+    clear();
+}
+
+void RTCVoidRequestPromiseImpl::clear()
+{
+    m_requester.clear();
+}
+
+DEFINE_TRACE(RTCVoidRequestPromiseImpl)
+{
+    visitor->trace(m_resolver);
+    visitor->trace(m_requester);
+    RTCVoidRequest::trace(visitor);
+}
+
+} // namespace blink