third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt - Issue 1661493002: Add promise-based addIceCandidate, setLocalDescription and setRemoteDescription to RTCPeerConnection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt

Issue 1661493002: Add promise-based addIceCandidate, setLocalDescription and setRemoteDescription to RTCPeerConnection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return resolved promises with undefined Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html ('k') | third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice-promise.html » ('j') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt

diff --git a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt

index c8ab6b1425b4e48deed5c564593727ee35bbf0ac..b43adc6e7bcc5036be91cae5bf115ce642d153b9 100644

--- a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt

+++ b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt

@@ -5,10 +5,16 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE

PASS pc = new webkitRTCPeerConnection(null, null); did not throw exception.

PASS iceConnectionState is completed

-PASS pc.addIceCandidate(null, addIceCandidateSuccess, addIceCandidateFailure); threw exception TypeError: Failed to execute 'addIceCandidate' on 'RTCPeerConnection': parameter 1 is not of type 'RTCIceCandidate'..

-PASS pc.addIceCandidate(iceCandidate, null, addIceCandidateFailure); threw exception TypeError: Failed to execute 'addIceCandidate' on 'RTCPeerConnection': The callback provided as parameter 2 is not a function..

-PASS pc.addIceCandidate(iceCandidate, addIceCandidateSuccess, null); threw exception TypeError: Failed to execute 'addIceCandidate' on 'RTCPeerConnection': The callback provided as parameter 3 is not a function..

+PASS pc.addIceCandidate(null, addIceCandidateSuccess, addIceCandidateFailure).catch(expectedTypeError); did not throw exception.

+PASS pc.addIceCandidate(iceCandidate, null, addIceCandidateFailure).catch(expectedTypeError); did not throw exception.

+PASS pc.addIceCandidate(iceCandidate, addIceCandidateSuccess, null).catch(expectedTypeError); did not throw exception.

PASS pc.addIceCandidate(iceCandidate, addIceCandidateSuccess, addIceCandidateFailure); did not throw exception.

+PASS TypeError is TypeError

+PASS expectedTypeError was called.

+PASS TypeError is TypeError

+PASS expectedTypeError was called.

+PASS TypeError is TypeError

+PASS expectedTypeError was called.

PASS addIceCandidateSuccess was called.

PASS iceConnectionState is closed.

PASS successfullyParsed is true