Add promise-based addIceCandidate, setLocalDescription and setRemoteDescription to RTCPeerConnection

third_party/WebKit/Source/modules/mediastream/MediaErrorState.cpp

 /*
  * Copyright (C) 2015 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 81 matching lines @@
         // This is for the cases where we can't pass back a
         // NavigatorUserMediaError.
         // So far, we have this in the constructor of RTCPeerConnection,
         // which is due to be deprecated.
         // TODO(hta): Remove this code. https://crbug.com/576581
         target.throwDOMException(NotSupportedError, "Unsatisfiable constraint " + m_constraint);
         break;
     }
 }
 
+String MediaErrorState::getErrorMessage()
+{
+    switch (m_errorType) {
+    case NoError:
+        ASSERT_NOT_REACHED();
+        break;
+    case TypeError:
+    case DOMError:

[philipj_slow, 2016/02/15 10:22:21]

Also s/DOMError/DOMException/ here?

[Guido Urdaneta, 2016/02/15 16:56:51]

Done.

+        return m_message;
+    case ConstraintError:
+        // This is for the cases where we can't pass back a
+        // NavigatorUserMediaError.
+        // So far, we have this in the constructor of RTCPeerConnection,
+        // which is due to be deprecated.
+        // TODO(hta): Remove this code. https://crbug.com/576581
+        return "Unsatisfiable constraint " + m_constraint;

[haraken, 2016/02/13 15:07:18]

Shall we add:

  default:
    ASSERT_NOT_REACHED();

?

[Guido Urdaneta, 2016/02/15 16:56:51]

Done.

+    }
+
+    return String();
+}
+
 NavigatorUserMediaError* MediaErrorState::createError()
 {
     ASSERT(m_errorType == ConstraintError);
     return NavigatorUserMediaError::create(NavigatorUserMediaError::NameConstraintNotSatisfied, m_message, m_constraint);
 }
 
 
 } // namespace blink