Add promise-based addIceCandidate, setLocalDescription and setRemoteDescription to RTCPeerConnection

third_party/WebKit/Source/modules/mediastream/RTCVoidRequestPromiseImpl.cpp

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "modules/mediastream/RTCVoidRequestPromiseImpl.h"
+
+#include "bindings/core/v8/ScriptPromiseResolver.h"
+#include "core/dom/DOMError.h"
+#include "modules/mediastream/RTCPeerConnection.h"
+
+namespace blink {
+
+RTCVoidRequestPromiseImpl* RTCVoidRequestPromiseImpl::create(RTCPeerConnection* requester, ScriptPromiseResolver* resolver, const String& errorName)
+{
+    RTCVoidRequestPromiseImpl* request = new RTCVoidRequestPromiseImpl(requester, resolver, errorName);
+    request->suspendIfNeeded();
+    return request;
+}
+
+RTCVoidRequestPromiseImpl::RTCVoidRequestPromiseImpl(RTCPeerConnection* requester, ScriptPromiseResolver* resolver, const String& errorName)
+    : ActiveDOMObject(resolver->executionContext())
+    , m_resolver(resolver)
+    , m_errorName(errorName)
+    , m_requester(requester)
+{
+    ASSERT(m_resolver);
+    ASSERT(m_requester);
+}
+
+RTCVoidRequestPromiseImpl::~RTCVoidRequestPromiseImpl()
+{
+}
+
+void RTCVoidRequestPromiseImpl::requestSucceeded()
+{
+    bool shouldFireCallback = m_requester ? m_requester->shouldFireDefaultCallbacks() : false;

[philipj_slow, 2016/02/09 12:02:03]

true/false in ternary expressions can always be rewritten, here to m_requester
&& m_requested->shouldFireDefaultCallbacks() which I find slightly clearer.

[Guido Urdaneta, 2016/02/09 16:51:01]

Done.

+    if (shouldFireCallback)
+        m_resolver->resolve();
+
+    clear();
+}
+
+void RTCVoidRequestPromiseImpl::requestFailed(const String& error)
+{
+    bool shouldFireCallback = m_requester ? m_requester->shouldFireDefaultCallbacks() : false;
+    if (shouldFireCallback)
+        m_resolver->reject(DOMError::create(m_errorName, error));

[philipj_slow, 2016/02/09 12:02:03]

Ah, DOMError. Whatever the spec may say, we shouldn't be using DOMError anywhere
new, it's gone from most specs and jsbell@ and I have been trying to eliminate
it.

[Guido Urdaneta, 2016/02/09 16:51:01]

Should I use DOMException instead then?

[philipj_slow, 2016/02/09 18:59:17]

I would recommend that, yes. Is https://github.com/w3c/webrtc-pc/issues/319 the
right place to point out that DOMError should not be used, or is there a
separate spec issue? Should I file one?

+
+    clear();
+}
+
+void RTCVoidRequestPromiseImpl::stop()
+{
+    clear();
+}
+
+void RTCVoidRequestPromiseImpl::clear()
+{
+    m_resolver.clear();
+    m_requester.clear();
+}
+
+DEFINE_TRACE(RTCVoidRequestPromiseImpl)
+{
+    visitor->trace(m_resolver);
+    visitor->trace(m_requester);
+    RTCVoidRequest::trace(visitor);
+    ActiveDOMObject::trace(visitor);
+}
+
+} // namespace blink