Add promise-based addIceCandidate, setLocalDescription and setRemoteDescription to RTCPeerConnection

third_party/WebKit/Source/modules/mediastream/RTCVoidRequestPromiseImpl.cpp

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "modules/mediastream/RTCVoidRequestPromiseImpl.h"
+
+#include "bindings/core/v8/ScriptPromiseResolver.h"
+#include "core/dom/DOMException.h"
+#include "modules/mediastream/RTCPeerConnection.h"
+
+namespace blink {
+
+RTCVoidRequestPromiseImpl* RTCVoidRequestPromiseImpl::create(RTCPeerConnection* requester, ScriptPromiseResolver* resolver, const String& errorName)
+{
+    RTCVoidRequestPromiseImpl* request = new RTCVoidRequestPromiseImpl(requester, resolver, errorName);
+    return request;
+}
+
+RTCVoidRequestPromiseImpl::RTCVoidRequestPromiseImpl(RTCPeerConnection* requester, ScriptPromiseResolver* resolver, const String& errorName)
+    : m_resolver(resolver)
+    , m_errorName(errorName)
+    , m_requester(requester)
+{
+    ASSERT(m_resolver);
+    ASSERT(m_requester);
+    m_resolver->keepAliveWhilePending();
+}
+
+RTCVoidRequestPromiseImpl::~RTCVoidRequestPromiseImpl()
+{
+}
+
+void RTCVoidRequestPromiseImpl::requestSucceeded()
+{
+    bool shouldFireCallback = m_requester && m_requester->shouldFireDefaultCallbacks() && m_resolver->executionContext() && !m_resolver->executionContext()->activeDOMObjectsAreStopped();
+    if (shouldFireCallback)
+        m_resolver->resolve();
+
+    clear();
+}
+
+void RTCVoidRequestPromiseImpl::requestFailed(const String& error)
+{
+    bool shouldFireCallback = m_requester && m_requester->shouldFireDefaultCallbacks() && m_resolver->executionContext() && !m_resolver->executionContext()->activeDOMObjectsAreStopped();
+    if (shouldFireCallback)
+        m_resolver->reject(DOMException::create(error, m_errorName));

[philipj_slow, 2016/02/11 14:31:01]

This is invoking the constructor documented as "exposed to script" which isn't
used internally elsewhere. Can you the variant that takes ExceptionCode instead?

[Guido Urdaneta, 2016/02/11 17:00:13]

Done.

+
+    clear();
+}
+
+void RTCVoidRequestPromiseImpl::clear()
+{
+    m_resolver.clear();
+    m_requester.clear();
+}
+
+DEFINE_TRACE(RTCVoidRequestPromiseImpl)
+{
+    visitor->trace(m_resolver);
+    visitor->trace(m_requester);
+    RTCVoidRequest::trace(visitor);
+}
+
+} // namespace blink