Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1661483002: Revert of [regexp] implement /ui to mirror the implementation for /i. (Closed)

Created:
4 years, 10 months ago by Yang
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] implement /ui to mirror the implementation for /i. (patchset #2 id:20001 of https://codereview.chromium.org/1641613002/ ) Reason for revert: This test fails: assertEquals(["as"], /^a[\u017F]/ui.exec("as")); The reason is that we end up with a character class that is not stand alone, so we do not perform case folding on it correctly (with unicode flag). Original issue's description: > [regexp] implement /ui to mirror the implementation for /i. > > R=erik.corry@gmail.com, erikcorry@chromium.org > > Committed: https://crrev.com/eea1a4c003c559c99bcc9f08aa7eadf931975aad > Cr-Commit-Position: refs/heads/master@{#33655} TBR=erik.corry@gmail.com,erikcorry@chromium.org,erikcorry@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d77d657731342fb0d504c9de95d9b399f50ca02a Cr-Commit-Position: refs/heads/master@{#33676}

Patch Set 1 #

Patch Set 2 : add cause of revert as test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -153 lines) Patch
M src/regexp/jsregexp.h View 1 13 chunks +19 lines, -19 lines 0 comments Download
M src/regexp/jsregexp.cc View 1 35 chunks +114 lines, -126 lines 0 comments Download
M src/regexp/regexp-parser.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M src/unicode.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-strings.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/unicode-regexp-ignore-case.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/unicode-regexp-ignore-case-noi18n.js View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Yang
Created Revert of [regexp] implement /ui to mirror the implementation for /i.
4 years, 10 months ago (2016-02-02 11:34:30 UTC) #1
erikcorry
lgtm
4 years, 10 months ago (2016-02-02 11:38:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661483002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661483002/160001
4 years, 10 months ago (2016-02-02 11:41:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:160001)
4 years, 10 months ago (2016-02-02 11:44:11 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 11:44:59 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d77d657731342fb0d504c9de95d9b399f50ca02a
Cr-Commit-Position: refs/heads/master@{#33676}

Powered by Google App Engine
This is Rietveld 408576698