Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1661453002: Setting page selector text should not allow brace (Closed)

Created:
4 years, 10 months ago by ramya.v
Modified:
4 years, 10 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Setting page selector text should not allow brace Setting page selector text should not allow anything trailing to valid selector apart from whitespace. BUG=580956 Committed: https://crrev.com/c014a6371a4ce99b45b478e803e8147ea9c0f93f Cr-Commit-Position: refs/heads/master@{#372920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/css/CSSPageRuleTest.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParser.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ramya.v
PTAL! Thanks
4 years, 10 months ago (2016-02-02 06:39:24 UTC) #2
Timothy Loh
On 2016/02/02 06:39:24, ramya.v wrote: > PTAL! > > Thanks lgtm
4 years, 10 months ago (2016-02-02 06:40:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661453002/1
4 years, 10 months ago (2016-02-02 06:45:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/160535)
4 years, 10 months ago (2016-02-02 08:10:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661453002/1
4 years, 10 months ago (2016-02-02 08:43:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 10:20:48 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 10:21:47 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c014a6371a4ce99b45b478e803e8147ea9c0f93f
Cr-Commit-Position: refs/heads/master@{#372920}

Powered by Google App Engine
This is Rietveld 408576698