Restore try contexts when breaking out of async for loops

Restore try contexts when breaking out of async for loops

Restore the try context in the finally clause of the implicit
try-finally around await-for loops. This ensures that the context
is restored even when breaking out of the loop.

BUG=24935
R=fschneider@google.com, regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/fef73d59ad177c6689cec2d1bb103714727df978

[hausner, 2016-02-02 18:47:00]

Description was changed from

==========
Restore try contexts when breaking out of async for loops

Restore the try context in the finally clause of the implicit
try-finally around await-for loops. This ensures that the context
is restored even when breaking out of the loop.

BUG=24935
==========

to

==========
Restore try contexts when breaking out of async for loops

Restore the try context in the finally clause of the implicit
try-finally around await-for loops. This ensures that the context
is restored even when breaking out of the loop.

BUG=24935
==========

[hausner, 2016-02-02 18:47:00]

hausner@google.com changed reviewers:
+ fschneider@google.com

[hausner, 2016-02-02 19:14:12]

hausner@google.com changed reviewers:
+ regis@google.com

[hausner, 2016-02-02 19:15:44]

Regis, adding you as a reviewer. You have worked on restoring try contexts in
async code.

[regis, 2016-02-02 20:03:40]

lgtm, but it would be nice to add the test of the bug report as a regression
test.

[hausner, 2016-02-02 21:00:59]

Thanks. I was wondering too about the regression test. There isn't really much
to test, other than that it isn't crashing the VM. I'll add it, though.

[Florian Schneider, 2016-02-02 21:32:28]

Lgtm.

Use BUG=dartbug.com/yyy, otherwise rietveld will add a link to the chromium
issue with that number.

[hausner, 2016-02-02 21:33:18]

Description was changed from

==========
Restore try contexts when breaking out of async for loops

Restore the try context in the finally clause of the implicit
try-finally around await-for loops. This ensures that the context
is restored even when breaking out of the loop.

BUG=24935
==========

to

==========
Restore try contexts when breaking out of async for loops

Restore the try context in the finally clause of the implicit
try-finally around await-for loops. This ensures that the context
is restored even when breaking out of the loop.

BUG=24935
R=fschneider@google.com, regis@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fef73d59ad177c6689cec2d1bb103714727df978
==========

[hausner, 2016-02-02 21:33:19]

Committed patchset #2 (id:20001) manually as
fef73d59ad177c6689cec2d1bb103714727df978 (presubmit successful).