net/android/java/src/org/chromium/net/IRemoteAndroidKeyStoreInterface.aidl - Issue 166143002: Refactoring AndroidKeyStore to support a KeyStore running in another process

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/android/java/src/org/chromium/net/IRemoteAndroidKeyStoreInterface.aidl

Issue 166143002: Refactoring AndroidKeyStore to support a KeyStore running in another process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « net/android/java/src/org/chromium/net/IRemoteAndroidKeyStoreCallbacks.aidl ('k') | net/android/java/src/org/chromium/net/RemoteAndroidKeyStore.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 foo.bar = baz;	5 interface org.chomium.net.IRemoteAndroidKeyStore;
	enrico.ros 2014/11/14 06:03:52 The domain 'chomium.net' is incorrect (missing 'r' The domain 'chomium.net' is incorrect (missing 'r'). What is the purpose of creating an invalid .aidl file? It is not valid per the aidl syntax. The ninja rule that compiles aidl into java should use the inclusion paths and not the pre-compiled checked in file. ppi 2014/11/14 10:03:34 Thanks for catching this - would you like to put t Show quoted text On 2014/11/14 06:03:52, enrico.ros wrote: > The domain 'chomium.net' is incorrect (missing 'r'). > What is the purpose of creating an invalid .aidl file? > > It is not valid per the aidl syntax. The ninja rule that compiles aidl into java > should use the inclusion paths and not the pre-compiled checked in file. Thanks for catching this - would you like to put together a patch to address the issue?
	6 interface org.chromium.net.IRemoteAndroidKeyStoreCallbacks;

OLD	NEW