Refactoring AndroidKeyStore to support a KeyStore running in another process

net/android/keystore.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/android/keystore.h"
 
 #include <vector>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/logging.h"
 
-#include "jni/AndroidKeyStore_jni.h"
+#include "jni/AndroidKeyStoreBridge_jni.h"

[bulach, 2014/02/14 10:45:29]

if my suggestion above works, then this will become again AndroidKeyStore_jni.h,
and the calls below would be something like:
Java_AndroidKeyStore_getRSAKeyModulus(env, 
  Java_AndroidKey_getKeyStore(env, private_key_ref)));

or rather:
Java_AndroidKeyStore_getRSAKeyModulus(env, 
  AndroidKey::GetKeyStore(env, private_key_ref)));

where AndroidKey is a tiny .h/.cc exposing the GetKeyStore from java, and the
AndroidKeyStoreBridge will be gone..

wdyt?

[Yaron, 2014/02/14 19:36:56]

Done.

 
 using base::android::AttachCurrentThread;
 using base::android::HasException;
 using base::android::JavaByteArrayToByteVector;
 using base::android::ScopedJavaLocalRef;
 using base::android::ToJavaByteArray;
 using base::android::JavaArrayOfByteArrayToStringVector;
 
 namespace net {
 namespace android {
 
 bool GetRSAKeyModulus(
     jobject private_key_ref,
     std::vector<uint8>* result) {
   JNIEnv* env = AttachCurrentThread();
 
   ScopedJavaLocalRef<jbyteArray> modulus_ref =
-      Java_AndroidKeyStore_getRSAKeyModulus(env, private_key_ref);
+      Java_AndroidKeyStoreBridge_getRSAKeyModulus(env, private_key_ref);
   if (modulus_ref.is_null())
     return false;
 
   JavaByteArrayToByteVector(env, modulus_ref.obj(), result);
   return true;
 }
 
 bool GetDSAKeyParamQ(jobject private_key_ref,
                      std::vector<uint8>* result) {
   JNIEnv* env = AttachCurrentThread();
 
   ScopedJavaLocalRef<jbyteArray> q_ref =
-      Java_AndroidKeyStore_getDSAKeyParamQ(env, private_key_ref);
+      Java_AndroidKeyStoreBridge_getDSAKeyParamQ(env, private_key_ref);
   if (q_ref.is_null())
     return false;
 
   JavaByteArrayToByteVector(env, q_ref.obj(), result);
   return true;
 }
 
 bool GetECKeyOrder(jobject private_key_ref,
                    std::vector<uint8>* result) {
   JNIEnv* env = AttachCurrentThread();
 
   ScopedJavaLocalRef<jbyteArray> order_ref =
-      Java_AndroidKeyStore_getECKeyOrder(env, private_key_ref);
+      Java_AndroidKeyStoreBridge_getECKeyOrder(env, private_key_ref);
   if (order_ref.is_null())
     return false;
 
   JavaByteArrayToByteVector(env, order_ref.obj(), result);
   return true;
 }
 
 bool GetPrivateKeyEncodedBytes(jobject private_key,
                                std::vector<uint8>* result) {
   JNIEnv* env = AttachCurrentThread();
 
   ScopedJavaLocalRef<jbyteArray> encoded_ref =
-      Java_AndroidKeyStore_getPrivateKeyEncodedBytes(env, private_key);
+      Java_AndroidKeyStoreBridge_getPrivateKeyEncodedBytes(env, private_key);
   if (encoded_ref.is_null())
     return false;
 
   JavaByteArrayToByteVector(env, encoded_ref.obj(), result);
   return true;
 }
 
 bool RawSignDigestWithPrivateKey(
     jobject private_key_ref,
     const base::StringPiece& digest,
     std::vector<uint8>* signature) {
   JNIEnv* env = AttachCurrentThread();
 
   // Convert message to byte[] array.
   ScopedJavaLocalRef<jbyteArray> digest_ref =
       ToJavaByteArray(env,
                       reinterpret_cast<const uint8*>(digest.data()),
                       digest.length());
   DCHECK(!digest_ref.is_null());
 
   // Invoke platform API
   ScopedJavaLocalRef<jbyteArray> signature_ref =
-      Java_AndroidKeyStore_rawSignDigestWithPrivateKey(
+      Java_AndroidKeyStoreBridge_rawSignDigestWithPrivateKey(
           env, private_key_ref, digest_ref.obj());
   if (HasException(env) || signature_ref.is_null())
     return false;
 
   // Write signature to string.
   JavaByteArrayToByteVector(env, signature_ref.obj(), signature);
   return true;
 }
 
 PrivateKeyType GetPrivateKeyType(jobject private_key) {
   JNIEnv* env = AttachCurrentThread();
-  int type = Java_AndroidKeyStore_getPrivateKeyType(
+  int type = Java_AndroidKeyStoreBridge_getPrivateKeyType(
       env, private_key);
   return static_cast<PrivateKeyType>(type);
 }
 
 EVP_PKEY* GetOpenSSLSystemHandleForPrivateKey(jobject private_key) {
   JNIEnv* env = AttachCurrentThread();
   // Note: the pointer is passed as a jint here because that's how it
   // is stored in the Java object. Java doesn't have a primitive type
   // like intptr_t that matches the size of pointers on the host
   // machine, and Android only runs on 32-bit CPUs.
   //
   // Given that this routine shall only be called on Android < 4.2,
   // this won't be a problem in the far future (e.g. when Android gets
   // ported to 64-bit environments, if ever).
   int pkey =
-      Java_AndroidKeyStore_getOpenSSLHandleForPrivateKey(env, private_key);
+      Java_AndroidKeyStoreBridge_getOpenSSLHandleForPrivateKey(env, private_key);
   return reinterpret_cast<EVP_PKEY*>(pkey);
 }
 
+void ReleaseKey(jobject private_key) {
+  JNIEnv* env = AttachCurrentThread();
+  Java_AndroidKeyStoreBridge_releaseKey(env, private_key);
+  env->DeleteGlobalRef(private_key);
+}
+
 bool RegisterKeyStore(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android
 }  // namespace net