Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: content/public/browser/navigation_handle.cc

Issue 1661423002: Solidify Entry discarding logic (NavigationHandle keeps its ID) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: creis review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_handle.cc
diff --git a/content/public/browser/navigation_handle.cc b/content/public/browser/navigation_handle.cc
index 4926947a2e926cde7b3f25ea96bc20ae22680377..eb54943a34e1bd4d8ddb8395fc7505c655d327ed 100644
--- a/content/public/browser/navigation_handle.cc
+++ b/content/public/browser/navigation_handle.cc
@@ -24,10 +24,11 @@ WebContents* NavigationHandle::GetWebContents() {
scoped_ptr<NavigationHandle> NavigationHandle::CreateNavigationHandleForTesting(
const GURL& url,
RenderFrameHost* render_frame_host) {
+ FrameTreeNode* node =
+ static_cast<RenderFrameHostImpl*>(render_frame_host)->frame_tree_node();
scoped_ptr<NavigationHandleImpl> handle_impl = NavigationHandleImpl::Create(
- url,
- static_cast<RenderFrameHostImpl*>(render_frame_host)->frame_tree_node(),
- base::TimeTicks::Now());
+ url, node, base::TimeTicks::Now(),
+ node->navigator()->GetController()->GetPendingEntry());
return scoped_ptr<NavigationHandle>(std::move(handle_impl));
}

Powered by Google App Engine
This is Rietveld 408576698