Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 1661423002: Solidify Entry discarding logic (NavigationHandle keeps its ID) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: creis review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.cc
diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc
index 7cec5bf579bf362f9775f87bbadcb8483579a38b..03a53b8607b153951f30f49eb65a83ddf1e84ad6 100644
--- a/content/browser/frame_host/navigation_handle_impl.cc
+++ b/content/browser/frame_host/navigation_handle_impl.cc
@@ -13,6 +13,7 @@
#include "content/browser/service_worker/service_worker_navigation_handle.h"
#include "content/common/frame_messages.h"
#include "content/public/browser/content_browser_client.h"
+#include "content/public/browser/navigation_entry.h"
#include "content/public/common/browser_side_navigation_policy.h"
#include "content/public/common/content_client.h"
#include "net/url_request/redirect_info.h"
@@ -33,15 +34,17 @@ void UpdateThrottleCheckResult(
scoped_ptr<NavigationHandleImpl> NavigationHandleImpl::Create(
const GURL& url,
FrameTreeNode* frame_tree_node,
- const base::TimeTicks& navigation_start) {
- return scoped_ptr<NavigationHandleImpl>(
- new NavigationHandleImpl(url, frame_tree_node, navigation_start));
+ const base::TimeTicks& navigation_start,
+ const NavigationEntry* pending_nav_entry) {
+ return scoped_ptr<NavigationHandleImpl>(new NavigationHandleImpl(
+ url, frame_tree_node, navigation_start, pending_nav_entry));
}
NavigationHandleImpl::NavigationHandleImpl(
const GURL& url,
FrameTreeNode* frame_tree_node,
- const base::TimeTicks& navigation_start)
+ const base::TimeTicks& navigation_start,
+ const NavigationEntry* entry)
: url_(url),
is_post_(false),
has_user_gesture_(false),
@@ -54,7 +57,8 @@ NavigationHandleImpl::NavigationHandleImpl(
is_transferring_(false),
frame_tree_node_(frame_tree_node),
next_index_(0),
- navigation_start_(navigation_start) {
+ navigation_start_(navigation_start),
+ pending_nav_entry_id_(entry ? entry->GetUniqueID() : 0) {
DCHECK(!navigation_start.is_null());
GetDelegate()->DidStartNavigation(this);
}

Powered by Google App Engine
This is Rietveld 408576698