content/browser/frame_host/render_frame_host_impl.cc - Issue 1661423002: Solidify Entry discarding logic (NavigationHandle keeps its ID)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1661423002: Solidify Entry discarding logic (NavigationHandle keeps its ID) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unittest Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigator_impl.cc ('K') | « content/browser/frame_host/navigator_impl.cc ('k') | content/public/browser/navigation_handle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index c231724a78d2e4f3352f2f9342a67ed34a5a6370..7941f59dd588ab80f37bf01fb8148c6c4e474b29 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -1012,8 +1012,9 @@ void RenderFrameHostImpl::OnDidCommitProvisionalLoad(const IPC::Message& msg) {

// DidCommitProvisionalLoad IPC without a prior DidStartProvisionalLoad

// message.

if (!navigation_handle_) {

- navigation_handle_ = NavigationHandleImpl::Create(

- validated_params.url, frame_tree_node_, base::TimeTicks::Now());

+ navigation_handle_ =

+ NavigationHandleImpl::Create(validated_params.url, frame_tree_node_,

+ base::TimeTicks::Now(), nullptr);

}

accessibility_reset_count_ = 0;

« content/browser/frame_host/navigator_impl.cc ('K') | « content/browser/frame_host/navigator_impl.cc ('k') | content/public/browser/navigation_handle.cc » ('j') | no next file with comments »