Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 1661423002: Solidify Entry discarding logic (NavigationHandle keeps its ID) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix check that's invalid when base url has invalid url. Added TODO Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigation_request.h ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_request.cc
diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc
index 3bf3c6f193b37cd362e2dd16543b49827c8b58d9..a0e1e625c3293b2ecd0aa96fc32414444a4bb5a7 100644
--- a/content/browser/frame_host/navigation_request.cc
+++ b/content/browser/frame_host/navigation_request.cc
@@ -227,14 +227,14 @@ void NavigationRequest::BeginNavigation() {
frame_tree_node_, nullptr, scoped_ptr<StreamHandle>());
}
-void NavigationRequest::CreateNavigationHandle() {
+void NavigationRequest::CreateNavigationHandle(int pending_nav_entry_id) {
// TODO(nasko): Update the NavigationHandle creation to ensure that the
// proper values are specified for is_synchronous and is_srcdoc.
- navigation_handle_ =
- NavigationHandleImpl::Create(common_params_.url, frame_tree_node_,
- false, // is_synchronous
- false, // is_srcdoc
- common_params_.navigation_start);
+ navigation_handle_ = NavigationHandleImpl::Create(
+ common_params_.url, frame_tree_node_,
+ false, // is_synchronous
+ false, // is_srcdoc
+ common_params_.navigation_start, pending_nav_entry_id);
}
void NavigationRequest::TransferNavigationHandleOwnership(
« no previous file with comments | « content/browser/frame_host/navigation_request.h ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698