content/public/browser/navigation_handle.cc - Issue 1661423002: Solidify Entry discarding logic (NavigationHandle keeps its ID)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/navigation_handle.cc

Issue 1661423002: Solidify Entry discarding logic (NavigationHandle keeps its ID) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't initialize NavigationHandle with base url for data url Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/navigation_handle.cc

diff --git a/content/public/browser/navigation_handle.cc b/content/public/browser/navigation_handle.cc

index 857e17d74f9c6589ce3e313ac4150bb200569e4f..c013c0ee19e7ebc8b728856f68cc6483f3a460a0 100644

--- a/content/public/browser/navigation_handle.cc

+++ b/content/public/browser/navigation_handle.cc

@@ -29,7 +29,7 @@ scoped_ptr<NavigationHandle> NavigationHandle::CreateNavigationHandleForTesting(

static_cast<RenderFrameHostImpl*>(render_frame_host)->frame_tree_node(),

false, // is_synchronous

false, // is_srcdoc

- base::TimeTicks::Now());

+ base::TimeTicks::Now(), 0);

return scoped_ptr<NavigationHandle>(std::move(handle_impl));

}