Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1661423002: Solidify Entry discarding logic (NavigationHandle keeps its ID) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 44998359d6471848be4aeaa8caee6821506af5d2..a9032fe03efcea617fcdeaff31e4f2f93eee7b22 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1011,8 +1011,10 @@ void RenderFrameHostImpl::OnDidCommitProvisionalLoad(const IPC::Message& msg) {
// DidCommitProvisionalLoad IPC without a prior DidStartProvisionalLoad
// message.
if (!navigation_handle_) {
+ // There is no pending NavigationEntry in these cases, so pass 0 as the
+ // nav_id.
navigation_handle_ = NavigationHandleImpl::Create(
- validated_params.url, frame_tree_node_, base::TimeTicks::Now());
+ validated_params.url, frame_tree_node_, base::TimeTicks::Now(), 0);
}
accessibility_reset_count_ = 0;

Powered by Google App Engine
This is Rietveld 408576698