Issue 1661403002: Subzero. X86. Fixes bundle lock/unlock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1661403002: Subzero. X86. Fixes bundle lock/unlock. (Closed)

Created:
4 years, 10 months ago by John

Modified:
4 years, 10 months ago

Reviewers:
Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero. X86. Fixes bundle lock/unlock. The AutoMemorySandboxer does not have to emit a bundle lock/unlock pair for memory operations in x8632, but the current does emit it. This CL changes this behavior. BUG= R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8347abda1ca4dd3c9622b87b1b294ee96ea8270c

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/IceTargetLoweringX86Base.h	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Jim Stichnoth

LGTM. I notice that "make presubmit" doesn't do anything for spec+sandbox. I wonder if one ...

4 years, 10 months ago (2016-02-04 17:10:34 UTC) #3

John

4 years, 10 months ago (2016-02-04 17:12:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8347abda1ca4dd3c9622b87b1b294ee96ea8270c (presubmit successful).