Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1661383002: WebAssembly: add stack trace test (Closed)

Created:
4 years, 10 months ago by JF
Modified:
4 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

WebAssembly: add stack trace test The test currently only shows the JavaScript stack frames, I'll then add support for interleaved WebAssembly stack frames and update the test. R=titzer@chromium.org Committed: https://crrev.com/ad6b8542a87fa8f38b9bc01c5e58561d21cbb54f Cr-Commit-Position: refs/heads/master@{#33742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
A test/mjsunit/wasm/stack.js View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JF
4 years, 10 months ago (2016-02-04 15:38:46 UTC) #1
titzer
lgtm
4 years, 10 months ago (2016-02-04 16:01:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661383002/1
4 years, 10 months ago (2016-02-04 16:03:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 16:25:04 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 16:25:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad6b8542a87fa8f38b9bc01c5e58561d21cbb54f
Cr-Commit-Position: refs/heads/master@{#33742}

Powered by Google App Engine
This is Rietveld 408576698