Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1661333002: [interpreter] temporarily remove --ignition from test. (Closed)

Created:
4 years, 10 months ago by Yang
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] temporarily remove --ignition from test. This is to avoid polluting fuzzer seeds with the --ignition flag until we figure out something better. TBR=mstarzinger@chromium.org Committed: https://crrev.com/0f075613e74283bc3defce292a8cf94688f080ae Cr-Commit-Position: refs/heads/master@{#33729}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/mjsunit/ignition/stack-trace-source-position.js View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 9 (3 generated)
Yang
4 years, 10 months ago (2016-02-04 11:25:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661333002/1
4 years, 10 months ago (2016-02-04 11:26:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 11:46:48 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0f075613e74283bc3defce292a8cf94688f080ae Cr-Commit-Position: refs/heads/master@{#33729}
4 years, 10 months ago (2016-02-04 11:47:09 UTC) #6
Michael Starzinger
LGTM. Thanks!
4 years, 10 months ago (2016-02-04 11:51:08 UTC) #7
rmcilroy
4 years, 10 months ago (2016-02-04 13:19:13 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1661333002/diff/1/test/mjsunit/ignition/stack...
File test/mjsunit/ignition/stack-trace-source-position.js (left):

https://codereview.chromium.org/1661333002/diff/1/test/mjsunit/ignition/stack...
test/mjsunit/ignition/stack-trace-source-position.js:5: // Flags: --ignition
--ignition-filter=f
The ignition flag shouldn't be necessary anyway (you could also remove the
--ignition-filter I think) since the all the mjsunit tests are run with
--ignition explicitly during the Ignition step.

Powered by Google App Engine
This is Rietveld 408576698